Looks good. Reviewed-by: [email protected]
> -----Original Message----- > From: Fu, Siyuan > Sent: Tuesday, December 18, 2018 3:33 PM > To: Fu, Siyuan <[email protected]>; [email protected] > Cc: Yao, Jiewen <[email protected]>; Kubacki, Michael A > <[email protected]> > Subject: RE: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg > PXE/iSCSI/TCP with NetworkPkg Drivers. > > Hi, Jiewen and Kubacki > > Do you have any comments for this patch? > > BestRegards > Fu Siyuan > > > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of > Fu > > Siyuan > > Sent: Friday, December 14, 2018 2:32 PM > > To: [email protected] > > Cc: Yao, Jiewen <[email protected]>; Kubacki, Michael A > > <[email protected]> > > Subject: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg > PXE/iSCSI/TCP with > > NetworkPkg Drivers. > > > > The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated. > All > > platform DSC/FDF files should be updated to use the dual-stack drivers in > > NetworkPkg. > > > > Cc: Michael A Kubacki <[email protected]> > > Cc: Jiewen Yao <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Fu Siyuan <[email protected]> > > --- > > > Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude. > dsc | 7 > > ++----- > > > Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude. > fdf | 7 > > ++----- > > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > | 3 > > +-- > > 3 files changed, 5 insertions(+), 12 deletions(-) > > > > diff --git > > > a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud > e.dsc > > > b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud > e.dsc > > index 4d70db6062..6764d46131 100644 > > --- > a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud > e.dsc > > +++ > b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud > e.dsc > > @@ -1,7 +1,7 @@ > > ## @file > > # Platform description. > > # > > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR> > > # > > # This program and the accompanying materials are licensed and made > available > > under > > # the terms and conditions of the BSD License which accompanies this > > distribution. > > @@ -26,10 +26,7 @@ > > MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > - MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > > MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > - MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > > - #MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > > > > NetworkPkg/Ip6Dxe/Ip6Dxe.inf > > NetworkPkg/TcpDxe/TcpDxe.inf > > @@ -42,7 +39,7 @@ > > NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > > NetworkPkg/HttpBootDxe/HttpBootDxe.inf > > > > - #NetworkPkg/IScsiDxe/IScsiDxe.inf > > + NetworkPkg/IScsiDxe/IScsiDxe.inf > > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > !endif > > > > diff --git > > > a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud > e.fdf > > > b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud > e.fdf > > index 0be408d13b..64f1dd5872 100644 > > --- > > > a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud > e.fdf > > +++ > > > b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud > e.fdf > > @@ -1,7 +1,7 @@ > > ## @file > > # FDF file of Platform. > > # > > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR> > > # > > # This program and the accompanying materials are licensed and made > available > > under > > # the terms and conditions of the BSD License which accompanies this > > distribution. > > @@ -27,9 +27,6 @@ INF > MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > -#INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > > -INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > > -#INF > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > > > > INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf > > INF NetworkPkg/TcpDxe/TcpDxe.inf > > @@ -42,7 +39,7 @@ INF NetworkPkg/HttpDxe/HttpDxe.inf > > INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > > INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf > > > > -#INF NetworkPkg/IScsiDxe/IScsiDxe.inf > > +INF NetworkPkg/IScsiDxe/IScsiDxe.inf > > INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > !endif > > > > diff --git > a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > index 2174eaa609..dd0173a1af 100644 > > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > @@ -1,7 +1,7 @@ > > ## @file > > # Platform description. > > # > > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR> > > # > > # This program and the accompanying materials are licensed and made > available > > under > > # the terms and conditions of the BSD License which accompanies this > > distribution. > > @@ -83,7 +83,6 @@ > > UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > > DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > > - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > > > > > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN > ull/OemHookStat > > usCodeLibNull.inf > > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in > f > > > > -- > > 2.19.1.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
