Reviewed-by: Zailiang Sun <[email protected]> > -----Original Message----- > From: Qian, Yi > Sent: Wednesday, December 19, 2018 11:08 AM > To: Zeng, Star <[email protected]>; [email protected] > Cc: Sun, Zailiang <[email protected]>; Wei, David <[email protected]> > Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement > > Reviewed-by: Yi Qian <[email protected]> > > Thanks > Qian Yi > > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, December 19, 2018 9:23 AM > To: Qian, Yi <[email protected]>; [email protected] > Cc: Sun, Zailiang <[email protected]>; Wei, David <[email protected]>; > Zeng, Star <[email protected]> > Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement > > Yi, Zailiang and David, > > So, is it ok to give RB to the patch from you? :) > > > Thanks, > Star > -----Original Message----- > From: Qian, Yi > Sent: Wednesday, December 19, 2018 9:21 AM > To: Zeng, Star <[email protected]>; [email protected] > Cc: Sun, Zailiang <[email protected]>; Wei, David <[email protected]> > Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement > > It's fine. Thank you for your update. > > Thanks > Qian Yi > > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, December 18, 2018 7:01 PM > To: Qian, Yi <[email protected]>; [email protected] > Cc: Sun, Zailiang <[email protected]>; Wei, David <[email protected]>; > Zeng, Star <[email protected]> > Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement > > Yi, > > Good question. > > With the patch, the code can be compiled and the image can boot to setup. > The image could not find shell, but that is not related to the patch. > It is because > https://github.com/tianocore/edk2/commit/2840bb51040bb79c1ad53b1eb1cbb > 86e5edf80ca#diff-0318cca23f8f1c46d1076b3a5891fadd updated the platform > dsc and fdf to use 2.0 shell source build (with 2.0 shell file GUID), but the > code at > https://github.com/tianocore/edk2/blob/master/Vlv2TbltDevicePkg/Library/Pla > tformBdsLib/BdsPlatform.c#L1365 is still using PcdShellFile (which matches to > EDK shell) to find shell file. > > > Thanks, > Star > -----Original Message----- > From: Qian, Yi > Sent: Tuesday, December 18, 2018 10:08 AM > To: Zeng, Star <[email protected]>; [email protected] > Cc: Sun, Zailiang <[email protected]> > Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement > > Hi Star, > This patch is good to me. Only one thing I need to know is whether you have > done the unit test, at least, compilation, and boot into shell. > > Thanks > Qian Yi > > -----Original Message----- > From: Zeng, Star > Sent: Friday, December 14, 2018 6:29 PM > To: [email protected] > Cc: Zeng, Star <[email protected]>; Sun, Zailiang <[email protected]>; > Qian, Yi <[email protected]> > Subject: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 > > The codes have been updated to not use PcdPeiCoreMaxFvSupported, > PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their statement > in platform DSC could be removed. > > Cc: Zailiang Sun <[email protected]> > Cc: Yi Qian <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng <[email protected]> > --- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 -- > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 -- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 -- > 3 files changed, 6 deletions(-) > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > index f8ad29df5986..d43611550285 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > @@ -663,10 +663,8 @@ [PcdsFixedAtBuild.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x400 > gEfiCpuTokenSpaceGuid.PcdCpuIEDRamSize|0x400000 > > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdS3AcpiReservedMemorySize > |0x10000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|50 > gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPpiSupported|128 > gEfiCpuTokenSpaceGuid.PcdCpuSmmApSyncTimeout|1000 > !if $(S4_ENABLE) == TRUE > > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChang > e|TRUE > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index ca3b2ff90287..a33816c4d18b 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -663,10 +663,8 @@ [PcdsFixedAtBuild.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x400 > gEfiCpuTokenSpaceGuid.PcdCpuIEDRamSize|0x400000 > > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdS3AcpiReservedMemorySize > |0x10000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|50 > gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPpiSupported|128 > gEfiCpuTokenSpaceGuid.PcdCpuSmmApSyncTimeout|1000 > !if $(S4_ENABLE) == TRUE > > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChang > e|TRUE > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 81f36bd73b28..b50731f25ffb 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -663,10 +663,8 @@ [PcdsFixedAtBuild.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x400 > gEfiCpuTokenSpaceGuid.PcdCpuIEDRamSize|0x400000 > > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdS3AcpiReservedMemorySize > |0x10000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|50 > gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPpiSupported|128 > gEfiCpuTokenSpaceGuid.PcdCpuSmmApSyncTimeout|1000 > !if $(S4_ENABLE) == TRUE > > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChang > e|TRUE > -- > 2.7.0.windows.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
