Reviewed-by: Jian J Wang <[email protected]>
> -----Original Message-----
> From: Wu, Hao A
> Sent: Friday, December 21, 2018 11:11 AM
> To: [email protected]
> Cc: Wu, Hao A <[email protected]>; Ard Biesheuvel
> <[email protected]>; Yao, Jiewen <[email protected]>; Gao,
> Liming <[email protected]>; Wang, Jian J <[email protected]>
> Subject: [PATCH v1 2/5] MdeModulePkg/FaultTolerantWrite: Update to
> consume SpeculationBarrier
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1417
>
> Since BaseLib API AsmLfence() is a x86 arch specific API and should be
> avoided using in generic codes, this commit replaces the usage of
> AsmLfence() with arch-generic API SpeculationBarrier().
>
> Cc: Ard Biesheuvel <[email protected]>
> Cc: Jiewen Yao <[email protected]>
> Cc: Liming Gao <[email protected]>
> Cc: Jian J Wang <[email protected]>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <[email protected]>
> ---
> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.c | 8
> ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.c
> b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.c
> index 27fcab19b6..481fea3f1f 100644
> ---
> a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.c
> +++
> b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.c
> @@ -419,11 +419,11 @@ SmmFaultTolerantWriteHandler (
> );
> if (!EFI_ERROR (Status)) {
> //
> - // The AsmLfence() call here is to ensure the previous range/content
> - // checks for the CommBuffer have been completed before calling into
> - // FtwWrite().
> + // The SpeculationBarrier() call here is to ensure the previous
> + // range/content checks for the CommBuffer have been completed before
> + // calling into FtwWrite().
> //
> - AsmLfence ();
> + SpeculationBarrier ();
> Status = FtwWrite(
> &mFtwDevice->FtwInstance,
> SmmFtwWriteHeader->Lba,
> --
> 2.12.0.windows.1
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
