On 12/24/18 03:12, Eric Dong wrote: > Directly call the API instead of create function for it. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1411 > > Cc: Ruiyu Ni <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong <[email protected]> > Reviewed-by: Ruiyu Ni <[email protected]> > --- > .../PeiRegisterCpuFeaturesLib.c | 35 > +++++----------------- > 1 file changed, 8 insertions(+), 27 deletions(-) > > diff --git > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c > index 0bbcb50181..fdd0791c89 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c > @@ -67,32 +67,6 @@ GetCpuFeaturesData ( > return CpuInitData; > } > > -/** > - Worker function to get MP PPI service pointer. > - > - @return PEI PPI service pointer. > -**/ > -EFI_PEI_MP_SERVICES_PPI * > -GetMpPpi ( > - VOID > - ) > -{ > - EFI_STATUS Status; > - EFI_PEI_MP_SERVICES_PPI *CpuMpPpi; > - > - // > - // Get MP Services Protocol > - // > - Status = PeiServicesLocatePpi ( > - &gEfiPeiMpServicesPpiGuid, > - 0, > - NULL, > - (VOID **)&CpuMpPpi > - ); > - ASSERT_EFI_ERROR (Status); > - return CpuMpPpi; > -} > - > /** > Worker function to return processor index. > > @@ -139,7 +113,14 @@ GetProcessorInformation ( > EFI_PEI_MP_SERVICES_PPI *CpuMpPpi; > EFI_STATUS Status; > > - CpuMpPpi = GetMpPpi (); > + Status = PeiServicesLocatePpi ( > + &gEfiPeiMpServicesPpiGuid, > + 0, > + NULL, > + (VOID **)&CpuMpPpi > + ); > + ASSERT_EFI_ERROR (Status); > + > Status = CpuMpPpi->GetProcessorInfo ( > GetPeiServicesTablePointer(), > CpuMpPpi, >
Reviewed-by: Laszlo Ersek <[email protected]> _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
