On Thu Dec 20, 2018 at 09:46:34AM +0100, Ard Biesheuvel wrote: > On Thu, 20 Dec 2018 at 06:48, Sughosh Ganu <[email protected]> wrote: > > > > Add the build infrastructure for compilation of StandaloneMm image > > files and FD file. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Sughosh Ganu <[email protected]> > > --- > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 130 > > +++++++++++++++++++++++++++ > > Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 100 +++++++++++++++++++++ > > 2 files changed, 230 insertions(+) > > create mode 100644 Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > create mode 100644 Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf
<snip> > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > > b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > > new file mode 100644 > > index 000000000000..6b9d1e703869 > > --- /dev/null > > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > > @@ -0,0 +1,100 @@ > > +# > > +# Copyright (c) 2018, ARM Limited. All rights reserved. > > +# > > +# This program and the accompanying materials are licensed and made > > available > > +# under the terms and conditions of the BSD License which accompanies this > > +# distribution. The full text of the license may be found at > > +# http://opensource.org/licenses/bsd-license.php > > +# > > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > > IMPLIED. > > +# > > + > > +################################################################################ > > +# > > +# FD Section > > +# The [FD] Section is made up of the definition statements and a > > +# description of what goes into the Flash Device Image. Each FD section > > +# defines one flash "device" image. A flash device image may be one of > > +# the following: Removable media bootable image (like a boot floppy > > +# image,) an Option ROM image (that would be "flashed" into an add-in > > +# card,) a System "Flash" image (that would be burned into a system's > > +# flash) or an Update ("Capsule") image that will be used to update and > > +# existing system flash. > > +# > > +################################################################################ > > + > > +[FD.BL32_AP_MM] > > +BaseAddress = 0xff200000|gArmTokenSpaceGuid.PcdFdBaseAddress # UEFI in > > DRAM + 128MB. > > +Size = 0x00e00000|gArmTokenSpaceGuid.PcdFdSize # The size > > in bytes of the device (64MiB). > > +ErasePolarity = 1 > > Indent ^^ > > > + > > +# This one is tricky, it must be: BlockSize * NumBlocks = Size > > Please drop the silly line above > > > +BlockSize = 0x00001000 > > +NumBlocks = 0x0e00 > > + > > indent ^^^ > > > +0x00000000|0x00280000 > > +gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > > +FV = FVMAIN_COMPACT > > + > > +[FV.FVMAIN_COMPACT] > > +FvAlignment = 16 > > +ERASE_POLARITY = 1 > > +MEMORY_MAPPED = TRUE > > +STICKY_WRITE = TRUE > > +LOCK_CAP = TRUE > > +LOCK_STATUS = TRUE > > +WRITE_DISABLED_CAP = TRUE > > +WRITE_ENABLED_CAP = TRUE > > +WRITE_STATUS = TRUE > > +WRITE_LOCK_CAP = TRUE > > +WRITE_LOCK_STATUS = TRUE > > +READ_DISABLED_CAP = TRUE > > +READ_ENABLED_CAP = TRUE > > +READ_STATUS = TRUE > > +READ_LOCK_CAP = TRUE > > +READ_LOCK_STATUS = TRUE > > Indent ^^ Can you tell me what is the correct indentation here. I checked multiple platforms and they all seem to be using the same indentation. Or am i missing something here. -sughosh _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel

