Hi Liming, On 12/24/18 16:01, Liming Gao wrote: > From: Ard Biesheuvel <[email protected]> > > This drops ARM and AARCH64 support from the GCC46 and GCC47 toolchain > definitions, which are on the list to be removed, along with VS2003, > VS2005, VS2008, VS2010, DDK3790, UNIXGCC, GCC44, GCC45, ELFGCC, CYGGCC, > ICC, ICC11 and MYTOOLS. > > Since GCC46 and GCC47 are the only ones on that list that support ARM > and/or AARCH64, let's give Liming a hand and cover the ARM side of > things first, so that everything that remains to be removed is x86 > only. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <[email protected]> > --- > BaseTools/Conf/tools_def.template | 143 > ++++---------------------------------- > 1 file changed, 14 insertions(+), 129 deletions(-) >
(1) I think you need to append at least your S-o-b, at the bottom of the commit message. (2) If this patch is 100% identical to <[email protected]">http://mid.mail-archive.com/[email protected]>, then please pick up all the review tags given in that thread (from Leif, yourself, and me). The idea is that you are forwarding / including this patch from Ard, so I believe the final list of tags should be: Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <[email protected]> Reviewed-by: Leif Lindholm <[email protected]> Reviewed-by: Laszlo Ersek <[email protected]> Reviewed-by: Liming Gao <[email protected]> Signed-off-by: Liming Gao <[email protected]> Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
