Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, December 25, 2018 12:17 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> > Subject: [PATCH v4 7/7] ShellPkg/UefiShellLib: Use BaseLib api CharToUpper > Importance: High > > Substitute InternalShellCharToUpper with CharToUpper which is a public > function with the same effect. > Remove the implement of InternalShellCharToUpper. > https://bugzilla.tianocore.org/show_bug.cgi?id=1369 > > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jaben Carsey <jaben.car...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 31 ++------------------ > 1 file changed, 2 insertions(+), 29 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index b17266d623..aff933dcdf 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -3740,33 +3740,6 @@ ShellFileExists( > return (EFI_SUCCESS); > } > > -/** > - Convert a Unicode character to upper case only if > - it maps to a valid small-case ASCII character. > - > - This internal function only deal with Unicode character > - which maps to a valid small-case ASCII character, i.e. > - L'a' to L'z'. For other Unicode character, the input character > - is returned directly. > - > - @param Char The character to convert. > - > - @retval LowerCharacter If the Char is with range L'a' to L'z'. > - @retval Unchanged Otherwise. > - > -**/ > -CHAR16 > -InternalShellCharToUpper ( > - IN CHAR16 Char > - ) > -{ > - if (Char >= L'a' && Char <= L'z') { > - return (CHAR16) (Char - (L'a' - L'A')); > - } > - > - return Char; > -} > - > /** > Convert a Unicode character to numerical value. > > @@ -3789,7 +3762,7 @@ InternalShellHexCharToUintn ( > return Char - L'0'; > } > > - return (10 + InternalShellCharToUpper (Char) - L'A'); > + return (10 + CharToUpper (Char) - L'A'); > } > > /** > @@ -3849,7 +3822,7 @@ InternalShellStrHexToUint64 ( > String++; > } > > - if (InternalShellCharToUpper (*String) == L'X') { > + if (CharToUpper (*String) == L'X') { > if (*(String - 1) != L'0') { > return 0; > } > -- > 2.18.0.windows.1
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
