Ard: Why need to change module type? The non-base type library can support more than one module types, such as MdeModulePkg\Library\PeiDxeDebugLibReportStatusCode\PeiDxeDebugLibReportStatusCode.inf. Only if this library has constructor and needs to support cross module type, it must be set to BASE. For other case, its module type can be kept as-is. I clarify this rule in https://lists.01.org/pipermail/edk2-devel/2018-December/033523.html.
Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Ard > Biesheuvel > Sent: Wednesday, January 2, 2019 9:05 PM > To: Jagadeesh Ujja <[email protected]> > Cc: [email protected]; Zhang, Chao B <[email protected]>; Gao, > Liming <[email protected]> > Subject: Re: [edk2] [PATCH 10/13] MdeModulePkg/VarCheckLib: allow > MM_STANDALONE drivers to use this library > > On Fri, 14 Dec 2018 at 13:14, Jagadeesh Ujja <[email protected]> wrote: > > > > “VarCheckLib” library can be used by MM_STANDALONE drivers as well. > > So add MM_STANDALONE as the module type this library supports. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Jagadeesh Ujja <[email protected]> > > --- > > MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > > b/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > > index 099f83d..c8cf810 100644 > > --- a/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > > +++ b/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > > @@ -2,6 +2,7 @@ > > # Provides variable check services and database management. > > # > > # Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> > > +# Copyright (c) 2018, ARM Limited. All rights reserved.<BR> > > # > > # This program and the accompanying materials > > # are licensed and made available under the terms and conditions > > @@ -21,12 +22,12 @@ > > FILE_GUID = 63E12D08-0C5D-47F8-95E4-09F89D7506C5 > > MODULE_TYPE = DXE_RUNTIME_DRIVER > > Please change the module type to 'BASE' as well. Note that this may > require you to add > > #include <Uefi/UefiBaseType.h> > > to some source or header files. > > With that > > Reviewed-by: Ard Biesheuvel <[email protected]> > > > VERSION_STRING = 1.0 > > - LIBRARY_CLASS = VarCheckLib|DXE_RUNTIME_DRIVER > > DXE_SMM_DRIVER > > + LIBRARY_CLASS = VarCheckLib|DXE_RUNTIME_DRIVER > > DXE_SMM_DRIVER MM_STANDALONE > > > > # > > # The following information is for reference only and not required by the > > build tools. > > # > > -# VALID_ARCHITECTURES = IA32 X64 > > +# VALID_ARCHITECTURES = IA32 X64 AARCH64 > > # > > > > [Sources] > > -- > > 2.7.4 > > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
