Reviewed-by: Jian J Wang <[email protected]> > -----Original Message----- > From: Wu, Hao A > Sent: Friday, January 04, 2019 10:42 AM > To: [email protected] > Cc: Wu, Hao A <[email protected]>; Bi, Dandan <[email protected]>; > Wang, Jian J <[email protected]>; Ni, Ray <[email protected]> > Subject: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix VS2015 IA32 NOOPT > build failure > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1425 > > This commit will resolve the VS2015 IA32 NOOPT build failure within > SdMmcPciHcDxe. > > More specifically, this commit will use BaseLib API RShiftU64() to perform > right-shift operations for UINT64 type operators. > > Cc: Dandan Bi <[email protected]> > Cc: Jian J Wang <[email protected]> > Cc: Ruiyu Ni <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu <[email protected]> > --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > index 6086720fa1..5aec8c6992 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > @@ -1505,7 +1505,7 @@ BuildAdmaDescTable ( > Trb->Adma32Desc[Index].Valid = 1; > Trb->Adma32Desc[Index].Act = 2; > if (DataLength26) { > - Trb->Adma32Desc[Index].UpperLength = (UINT16)(Remaining >> 16); > + Trb->Adma32Desc[Index].UpperLength = (UINT16)RShiftU64 (Remaining, > 16); > } > Trb->Adma32Desc[Index].LowerLength = (UINT16)(Remaining & > MAX_UINT16); > Trb->Adma32Desc[Index].Address = (UINT32)Address; > @@ -1524,11 +1524,11 @@ BuildAdmaDescTable ( > Trb->Adma64Desc[Index].Valid = 1; > Trb->Adma64Desc[Index].Act = 2; > if (DataLength26) { > - Trb->Adma64Desc[Index].UpperLength = (UINT16)(Remaining >> 16); > + Trb->Adma64Desc[Index].UpperLength = (UINT16)RShiftU64 (Remaining, > 16); > } > Trb->Adma64Desc[Index].LowerLength = (UINT16)(Remaining & > MAX_UINT16); > Trb->Adma64Desc[Index].LowerAddress = (UINT32)Address; > - Trb->Adma64Desc[Index].UpperAddress = (UINT32)(Address >> 32); > + Trb->Adma64Desc[Index].UpperAddress = (UINT32)RShiftU64 (Address, > 32); > break; > } else { > Trb->Adma64Desc[Index].Valid = 1; > @@ -1538,7 +1538,7 @@ BuildAdmaDescTable ( > } > Trb->Adma64Desc[Index].LowerLength = 0; > Trb->Adma64Desc[Index].LowerAddress = (UINT32)Address; > - Trb->Adma64Desc[Index].UpperAddress = (UINT32)(Address >> 32); > + Trb->Adma64Desc[Index].UpperAddress = (UINT32)RShiftU64 (Address, > 32); > } > } > > -- > 2.12.0.windows.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
