Got it. I will update the commit message with the warning message "equality comparison with extraneous parentheses".
Thanks Liming > -----Original Message----- > From: Laszlo Ersek [mailto:[email protected]] > Sent: Monday, January 14, 2019 10:36 PM > To: Gao, Liming <[email protected]>; [email protected] > Subject: Re: [edk2] [Patch] BaseTools GenFw: Fix XCODE5 build issue > > On 01/14/19 14:52, Liming Gao wrote: > > Remove extraneous parentheses around the comparison to silence this warning. > > Can you please quote the warning message in the commit message? It's > unclear what warning the commit message refers to. (No need to repost > just for this.) > > Thanks > Laszlo > > > This issue is caused by commit 8daa4278e80c70e6caabc525cd122744488253f5. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Liming Gao <[email protected]> > > Cc: Feng Bob C <[email protected]> > > --- > > BaseTools/Source/C/GenFw/GenFw.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/BaseTools/Source/C/GenFw/GenFw.c > > b/BaseTools/Source/C/GenFw/GenFw.c > > index 37278bbc68..af2c909866 100644 > > --- a/BaseTools/Source/C/GenFw/GenFw.c > > +++ b/BaseTools/Source/C/GenFw/GenFw.c > > @@ -1014,7 +1014,7 @@ Returns: > > // > > // Update Image Base Address > > // > > - if ((ImgHdr->Pe32.OptionalHeader.Magic == > > EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC)) { > > + if (ImgHdr->Pe32.OptionalHeader.Magic == > > EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC) { > > ImgHdr->Pe32.OptionalHeader.ImageBase = (UINT32) NewPe32BaseAddress; > > } else if (ImgHdr->Pe32Plus.OptionalHeader.Magic == > > EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC) { > > ImgHdr->Pe32Plus.OptionalHeader.ImageBase = NewPe32BaseAddress; > > @@ -2180,7 +2180,7 @@ Returns: > > // Set new base address into image > > // > > if (mOutImageType == FW_REBASE_IMAGE || mOutImageType == > > FW_SET_ADDRESS_IMAGE) { > > - if ((PeHdr->Pe32.OptionalHeader.Magic == > > EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC)) { > > + if (PeHdr->Pe32.OptionalHeader.Magic == > > EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC) { > > if (NewBaseAddress >= 0x100000000ULL) { > > Error (NULL, 0, 3000, "Invalid", "New base address is larger than > > 4G for 32bit PE image"); > > goto Finish; > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
