On Mon, 14 Jan 2019 at 15:10, Gao, Liming <[email protected]> wrote: > > Reviewed-by: Liming Gao <[email protected]> >
Pushed as 17f5fd9291e0..e695e44545b4 Thanks all > > -----Original Message----- > > From: Philippe Mathieu-Daudé [mailto:[email protected]] > > Sent: Monday, January 14, 2019 10:09 PM > > To: Ard Biesheuvel <[email protected]>; Gao, Liming > > <[email protected]>; [email protected] > > Cc: [email protected] > > Subject: Re: [PATCH v2] BaseTools/tools_def GCC5: disable LTO for ASLC > > invocations > > > > On 1/14/19 3:04 PM, Ard Biesheuvel wrote: > > > GCC for 32-bit ARM chokes on .aslc files when running with LTO > > > enabled. Since LTO has no benefit whatsoever here, just disable > > > it globally for GCC5 and up when building .aslc files. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel <[email protected]> > > > Reviewed-by: Leif Lindholm <[email protected]> > > > > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > > > > > --- > > > BaseTools/Conf/tools_def.template | 27 +++++++++++--------- > > > 1 file changed, 15 insertions(+), 12 deletions(-) > > > > > > diff --git a/BaseTools/Conf/tools_def.template > > > b/BaseTools/Conf/tools_def.template > > > index 4d74816837ab..2bd098287219 100755 > > > --- a/BaseTools/Conf/tools_def.template > > > +++ b/BaseTools/Conf/tools_def.template > > > @@ -4155,6 +4155,7 @@ DEFINE GCC48_AARCH64_DLINK_FLAGS = > > > DEF(GCC_AARCH64_DLINK_FLAGS) > > > DEFINE GCC48_AARCH64_DLINK2_FLAGS = DEF(GCC_DLINK2_FLAGS_COMMON) > > > -Wl,--defsym=PECOFF_HEADER_SIZE=0x228 > > > DEFINE GCC48_ARM_ASLDLINK_FLAGS = DEF(GCC_ARM_ASLDLINK_FLAGS) > > > -Wl,--oformat=elf32-littlearm > > > DEFINE GCC48_AARCH64_ASLDLINK_FLAGS = DEF(GCC_AARCH64_ASLDLINK_FLAGS) > > > +DEFINE GCC48_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) > > > > > > DEFINE GCC49_IA32_CC_FLAGS = DEF(GCC48_IA32_CC_FLAGS) > > > DEFINE GCC49_X64_CC_FLAGS = DEF(GCC48_X64_CC_FLAGS) > > > @@ -4177,6 +4178,7 @@ DEFINE GCC49_AARCH64_DLINK_FLAGS = > > > DEF(GCC48_AARCH64_DLINK_FLAGS) -z common- > > > DEFINE GCC49_AARCH64_DLINK2_FLAGS = DEF(GCC48_AARCH64_DLINK2_FLAGS) > > > DEFINE GCC49_ARM_ASLDLINK_FLAGS = DEF(GCC48_ARM_ASLDLINK_FLAGS) > > > DEFINE GCC49_AARCH64_ASLDLINK_FLAGS = DEF(GCC48_AARCH64_ASLDLINK_FLAGS) > > > +DEFINE GCC49_ASLCC_FLAGS = DEF(GCC48_ASLCC_FLAGS) > > > > > > DEFINE GCC5_IA32_CC_FLAGS = DEF(GCC49_IA32_CC_FLAGS) -fno-pic > > > -fno-pie > > > DEFINE GCC5_X64_CC_FLAGS = DEF(GCC49_X64_CC_FLAGS) > > > @@ -4199,6 +4201,7 @@ DEFINE GCC5_AARCH64_DLINK_FLAGS = > > > DEF(GCC49_AARCH64_DLINK_FLAGS) > > > DEFINE GCC5_AARCH64_DLINK2_FLAGS = DEF(GCC49_AARCH64_DLINK2_FLAGS) > > > -Wno-error > > > DEFINE GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC49_ARM_ASLDLINK_FLAGS) > > > DEFINE GCC5_AARCH64_ASLDLINK_FLAGS = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) > > > +DEFINE GCC5_ASLCC_FLAGS = DEF(GCC49_ASLCC_FLAGS) -fno-lto > > > > > > > > > #################################################################################### > > > # > > > @@ -4301,7 +4304,7 @@ DEFINE GCC5_AARCH64_ASLDLINK_FLAGS = > > > DEF(GCC49_AARCH64_ASLDLINK_FLAGS) > > > *_GCC48_IA32_ASLPP_PATH = DEF(GCC48_IA32_PREFIX)gcc > > > *_GCC48_IA32_RC_PATH = DEF(GCC48_IA32_PREFIX)objcopy > > > > > > -*_GCC48_IA32_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -m32 > > > +*_GCC48_IA32_ASLCC_FLAGS = DEF(GCC48_ASLCC_FLAGS) -m32 > > > *_GCC48_IA32_ASLDLINK_FLAGS = DEF(GCC48_IA32_X64_ASLDLINK_FLAGS) > > > -Wl,-m,elf_i386 > > > *_GCC48_IA32_ASM_FLAGS = DEF(GCC48_ASM_FLAGS) -m32 -march=i386 > > > *_GCC48_IA32_DLINK_FLAGS = DEF(GCC48_IA32_X64_DLINK_FLAGS) > > > -Wl,-m,elf_i386,--oformat=elf32-i386 > > > @@ -4329,7 +4332,7 @@ RELEASE_GCC48_IA32_CC_FLAGS = > > > DEF(GCC48_IA32_CC_FLAGS) -Os -Wno-unused-but > > > *_GCC48_X64_ASLPP_PATH = DEF(GCC48_X64_PREFIX)gcc > > > *_GCC48_X64_RC_PATH = DEF(GCC48_X64_PREFIX)objcopy > > > > > > -*_GCC48_X64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -m64 > > > +*_GCC48_X64_ASLCC_FLAGS = DEF(GCC48_ASLCC_FLAGS) -m64 > > > *_GCC48_X64_ASLDLINK_FLAGS = DEF(GCC48_IA32_X64_ASLDLINK_FLAGS) > > > -Wl,-m,elf_x86_64 > > > *_GCC48_X64_ASM_FLAGS = DEF(GCC48_ASM_FLAGS) -m64 > > > *_GCC48_X64_DLINK_FLAGS = DEF(GCC48_X64_DLINK_FLAGS) > > > @@ -4359,7 +4362,7 @@ RELEASE_GCC48_X64_CC_FLAGS = > > > DEF(GCC48_X64_CC_FLAGS) -Os -Wno-unused-but-s > > > *_GCC48_ARM_ARCHCC_FLAGS = -mthumb > > > *_GCC48_ARM_PLATFORM_FLAGS = -march=armv7-a > > > > > > -*_GCC48_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) > > > +*_GCC48_ARM_ASLCC_FLAGS = DEF(GCC48_ASLCC_FLAGS) > > > *_GCC48_ARM_ASLDLINK_FLAGS = DEF(GCC48_ARM_ASLDLINK_FLAGS) > > > *_GCC48_ARM_ASM_FLAGS = DEF(GCC48_ARM_ASM_FLAGS) > > > *_GCC48_ARM_DLINK_FLAGS = DEF(GCC48_ARM_DLINK_FLAGS) > > > @@ -4389,7 +4392,7 @@ RELEASE_GCC48_ARM_CC_FLAGS = > > > DEF(GCC48_ARM_CC_FLAGS) -Wno-unused-but-set-v > > > *_GCC48_AARCH64_ASLPP_PATH = ENV(GCC48_AARCH64_PREFIX)gcc > > > *_GCC48_AARCH64_RC_PATH = ENV(GCC48_AARCH64_PREFIX)objcopy > > > > > > -*_GCC48_AARCH64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) > > > +*_GCC48_AARCH64_ASLCC_FLAGS = DEF(GCC48_ASLCC_FLAGS) > > > *_GCC48_AARCH64_ASLDLINK_FLAGS = DEF(GCC48_AARCH64_ASLDLINK_FLAGS) > > > *_GCC48_AARCH64_ASM_FLAGS = DEF(GCC48_AARCH64_ASM_FLAGS) > > > *_GCC48_AARCH64_DLINK_FLAGS = DEF(GCC48_AARCH64_DLINK_FLAGS) > > > @@ -4440,7 +4443,7 @@ RELEASE_GCC48_AARCH64_CC_FLAGS = > > > DEF(GCC48_AARCH64_CC_FLAGS) -Wno-unused-but-s > > > *_GCC49_IA32_ASLPP_PATH = DEF(GCC49_IA32_PREFIX)gcc > > > *_GCC49_IA32_RC_PATH = DEF(GCC49_IA32_PREFIX)objcopy > > > > > > -*_GCC49_IA32_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -m32 > > > +*_GCC49_IA32_ASLCC_FLAGS = DEF(GCC49_ASLCC_FLAGS) -m32 > > > *_GCC49_IA32_ASLDLINK_FLAGS = DEF(GCC49_IA32_X64_ASLDLINK_FLAGS) > > > -Wl,-m,elf_i386 > > > *_GCC49_IA32_ASM_FLAGS = DEF(GCC49_ASM_FLAGS) -m32 -march=i386 > > > *_GCC49_IA32_DLINK_FLAGS = DEF(GCC49_IA32_X64_DLINK_FLAGS) > > > -Wl,-m,elf_i386,--oformat=elf32-i386 > > > @@ -4468,7 +4471,7 @@ RELEASE_GCC49_IA32_CC_FLAGS = > > > DEF(GCC49_IA32_CC_FLAGS) -Os -Wno-unused-but > > > *_GCC49_X64_ASLPP_PATH = DEF(GCC49_X64_PREFIX)gcc > > > *_GCC49_X64_RC_PATH = DEF(GCC49_X64_PREFIX)objcopy > > > > > > -*_GCC49_X64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -m64 > > > +*_GCC49_X64_ASLCC_FLAGS = DEF(GCC49_ASLCC_FLAGS) -m64 > > > *_GCC49_X64_ASLDLINK_FLAGS = DEF(GCC49_IA32_X64_ASLDLINK_FLAGS) > > > -Wl,-m,elf_x86_64 > > > *_GCC49_X64_ASM_FLAGS = DEF(GCC49_ASM_FLAGS) -m64 > > > *_GCC49_X64_DLINK_FLAGS = DEF(GCC49_X64_DLINK_FLAGS) > > > @@ -4498,7 +4501,7 @@ RELEASE_GCC49_X64_CC_FLAGS = > > > DEF(GCC49_X64_CC_FLAGS) -Os -Wno-unused-but-s > > > *_GCC49_ARM_ARCHCC_FLAGS = -mthumb > > > *_GCC49_ARM_PLATFORM_FLAGS = -march=armv7-a > > > > > > -*_GCC49_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) > > > +*_GCC49_ARM_ASLCC_FLAGS = DEF(GCC49_ASLCC_FLAGS) > > > *_GCC49_ARM_ASLDLINK_FLAGS = DEF(GCC49_ARM_ASLDLINK_FLAGS) > > > *_GCC49_ARM_ASM_FLAGS = DEF(GCC49_ARM_ASM_FLAGS) > > > *_GCC49_ARM_DLINK_FLAGS = DEF(GCC49_ARM_DLINK_FLAGS) > > > @@ -4528,7 +4531,7 @@ RELEASE_GCC49_ARM_CC_FLAGS = > > > DEF(GCC49_ARM_CC_FLAGS) -Wno-unused-but-set-v > > > *_GCC49_AARCH64_ASLPP_PATH = ENV(GCC49_AARCH64_PREFIX)gcc > > > *_GCC49_AARCH64_RC_PATH = ENV(GCC49_AARCH64_PREFIX)objcopy > > > > > > -*_GCC49_AARCH64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) > > > +*_GCC49_AARCH64_ASLCC_FLAGS = DEF(GCC49_ASLCC_FLAGS) > > > *_GCC49_AARCH64_ASLDLINK_FLAGS = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) > > > *_GCC49_AARCH64_ASM_FLAGS = DEF(GCC49_AARCH64_ASM_FLAGS) > > > *_GCC49_AARCH64_DLINK2_FLAGS = DEF(GCC49_AARCH64_DLINK2_FLAGS) > > > @@ -4586,7 +4589,7 @@ RELEASE_GCC49_AARCH64_DLINK_XIPFLAGS = -z > > > common-page-size=0x20 > > > *_GCC5_IA32_ASLPP_PATH = DEF(GCC5_IA32_PREFIX)gcc > > > *_GCC5_IA32_RC_PATH = DEF(GCC5_IA32_PREFIX)objcopy > > > > > > -*_GCC5_IA32_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -m32 -fno-lto > > > +*_GCC5_IA32_ASLCC_FLAGS = DEF(GCC5_ASLCC_FLAGS) -m32 > > > *_GCC5_IA32_ASLDLINK_FLAGS = DEF(GCC5_IA32_X64_ASLDLINK_FLAGS) > > > -Wl,-m,elf_i386 -no-pie > > > *_GCC5_IA32_ASM_FLAGS = DEF(GCC5_ASM_FLAGS) -m32 -march=i386 > > > *_GCC5_IA32_DLINK2_FLAGS = DEF(GCC5_IA32_DLINK2_FLAGS) -no-pie > > > @@ -4618,7 +4621,7 @@ RELEASE_GCC5_IA32_DLINK_FLAGS = > > > DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Os -Wl, > > > *_GCC5_X64_ASLPP_PATH = DEF(GCC5_X64_PREFIX)gcc > > > *_GCC5_X64_RC_PATH = DEF(GCC5_X64_PREFIX)objcopy > > > > > > -*_GCC5_X64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -m64 -fno-lto > > > +*_GCC5_X64_ASLCC_FLAGS = DEF(GCC5_ASLCC_FLAGS) -m64 > > > *_GCC5_X64_ASLDLINK_FLAGS = DEF(GCC5_IA32_X64_ASLDLINK_FLAGS) > > > -Wl,-m,elf_x86_64 > > > *_GCC5_X64_ASM_FLAGS = DEF(GCC5_ASM_FLAGS) -m64 > > > *_GCC5_X64_DLINK2_FLAGS = DEF(GCC5_X64_DLINK2_FLAGS) > > > @@ -4650,7 +4653,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = > > > DEF(GCC5_X64_DLINK_FLAGS) -flto -Os > > > *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy > > > > > > *_GCC5_ARM_ARCHCC_FLAGS = -mthumb > > > -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) > > > +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC5_ASLCC_FLAGS) > > > *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS) > > > *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS) > > > *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS) > > > @@ -4684,7 +4687,7 @@ RELEASE_GCC5_ARM_DLINK_FLAGS = > > > DEF(GCC5_ARM_DLINK_FLAGS) -flto -Os -L$(WORKS > > > *_GCC5_AARCH64_ASLPP_PATH = ENV(GCC5_AARCH64_PREFIX)gcc > > > *_GCC5_AARCH64_RC_PATH = ENV(GCC5_AARCH64_PREFIX)objcopy > > > > > > -*_GCC5_AARCH64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) > > > +*_GCC5_AARCH64_ASLCC_FLAGS = DEF(GCC5_ASLCC_FLAGS) > > > *_GCC5_AARCH64_ASLDLINK_FLAGS = DEF(GCC5_AARCH64_ASLDLINK_FLAGS) > > > *_GCC5_AARCH64_ASM_FLAGS = DEF(GCC5_AARCH64_ASM_FLAGS) > > > *_GCC5_AARCH64_DLINK2_FLAGS = DEF(GCC5_AARCH64_DLINK2_FLAGS) > > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
