On Wed, 16 Jan 2019 at 21:18, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Wed, Jan 02, 2019 at 02:00:44PM +0100, Ard Biesheuvel wrote: > > The library's MODULE_TYPE and the module type restrictions it > > defines are needlessly strict. Just change the library to BASE > > type and drop the restrictions entirely. Also, drop a bogus > > library dependency on DxeServicesLib. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> >
Thanks Pushed as 31f5388006fc..66cffa652512 > > --- > > EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > > b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > > index b4b33247fa52..ee207ae7e9d7 100644 > > --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > > +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > > @@ -16,9 +16,9 @@ [Defines] > > INF_VERSION = 0x00010019 > > BASE_NAME = NorFlashInfoLib > > FILE_GUID = 6b639c7e-9b53-4e9f-89a3-2e711729709c > > - MODULE_TYPE = DXE_DRIVER > > + MODULE_TYPE = BASE > > VERSION_STRING = 1.0 > > - LIBRARY_CLASS = NorFlashInfoLib|DXE_DRIVER > > DXE_RUNTIME_DRIVER UEFI_APPLICATION > > + LIBRARY_CLASS = NorFlashInfoLib > > > > [Sources] > > NorFlashInfoLib.c > > @@ -30,5 +30,4 @@ [Packages] > > [LibraryClasses] > > BaseLib > > DebugLib > > - DxeServicesLib > > MemoryAllocationLib > > -- > > 2.19.2 > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel