The patch is good. Reviewed-by: Liming Gao <liming....@intel.com>
Please add BZ number URL when push it.
Thanks
Liming
> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, January 16, 2019 11:30 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com>
> Subject: [Patch] BaseTools: Fix build report issue.
>
> The Pcd Array feature changes the Pcd Default value
> data structure which is used by build report. This
> patch is going to update build report to adapt that change.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.f...@intel.com>
> Cc: Liming Gao <liming....@intel.com>
> ---
> BaseTools/Source/Python/build/BuildReport.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/build/BuildReport.py
> b/BaseTools/Source/Python/build/BuildReport.py
> index 654a69e05c..ae37a6ce0e 100644
> --- a/BaseTools/Source/Python/build/BuildReport.py
> +++ b/BaseTools/Source/Python/build/BuildReport.py
> @@ -1243,13 +1243,15 @@ class PcdReport(object):
> Value = '{} ({:d})'.format(Value, int(Value, 0))
> else:
> Value = "0x{:X} ({})".format(int(Value, 0), Value)
> FileWrite(File, ' %*s = %s' % (self.MaxLen + 19, 'DEC
> DEFAULT', Value))
> if IsStructure:
> - self.PrintStructureInfo(File, Pcd.DefaultValues)
> + for filedvalues in Pcd.DefaultValues.values():
> + self.PrintStructureInfo(File, filedvalues)
> if DecMatch and IsStructure:
> - self.PrintStructureInfo(File, Pcd.DefaultValues)
> + for filedvalues in Pcd.DefaultValues.values():
> + self.PrintStructureInfo(File, filedvalues)
>
> def PrintPcdValue(self, File, Pcd, PcdTokenCName, TypeName, IsStructure,
> DscMatch, DscDefaultValue, InfMatch, InfDefaultValue,
> DecMatch, DecDefaultValue, Flag = ' '):
> if not Pcd.SkuInfoList:
> Value = Pcd.DefaultValue
> IsByteArray, ArrayList = ByteArrayForamt(Value)
> --
> 2.19.1.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
