This patch does not touch VarCheckLib at all, but only touch VarCheckUefiLib, so the title and commit message need be updated. With them updated correctly, Reviewed-by: Star Zeng <[email protected]>.
Thanks, Star -----Original Message----- From: Ard Biesheuvel [mailto:[email protected]] Sent: Thursday, January 17, 2019 5:22 AM To: [email protected] Cc: Ard Biesheuvel <[email protected]>; Kinney, Michael D <[email protected]>; Gao, Liming <[email protected]>; Ye, Ting <[email protected]>; Wei, Gang <[email protected]>; Wang, Jian J <[email protected]>; Zhang, Chao B <[email protected]>; Yao, Jiewen <[email protected]>; Wu, Hao A <[email protected]>; Zeng, Star <[email protected]>; Achin Gupta <[email protected]>; Jagadeesh Ujja <[email protected]> Subject: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules Permit VarCheckLib and VarCheckUefiLib to be used by MM_STANDALONE modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <[email protected]> --- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf | 4 ++-- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf index 128c44d695e1..8873fd51a02a 100644 --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf @@ -19,9 +19,9 @@ [Defines] BASE_NAME = VarCheckUefiLib MODULE_UNI_FILE = VarCheckUefiLib.uni FILE_GUID = AC24A4C7-F845-4665-90E5-6431D6E28DC0 - MODULE_TYPE = DXE_RUNTIME_DRIVER + MODULE_TYPE = BASE VERSION_STRING = 1.0 - LIBRARY_CLASS = NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER + LIBRARY_CLASS = NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER MM_STANDALONE CONSTRUCTOR = VarCheckUefiLibNullClassConstructor # diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c index 80dc6341adcf..5e419831e8cc 100644 --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c @@ -12,6 +12,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. **/ +#include <Uefi/UefiBaseType.h> + #include <Library/VarCheckLib.h> #include <Library/BaseLib.h> #include <Library/BaseMemoryLib.h> @@ -927,15 +929,14 @@ VariablePropertySetUefiDefined ( @retval EFI_SUCCESS The constructor executed correctly. **/ -EFI_STATUS +RETURN_STATUS EFIAPI VarCheckUefiLibNullClassConstructor ( - IN EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE *SystemTable + VOID ) { VariablePropertySetUefiDefined (); VarCheckLibRegisterSetVariableCheckHandler (SetVariableCheckHandlerUefiDefined); - return EFI_SUCCESS; + return RETURN_SUCCESS; } -- 2.17.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
