Hi Michael,

1) Is this content intended for a new branch or an 
   existing branch in the edk2-platforms repo?  The
   subject line of the commit message can help clarify
   this.  The required format is:

        [PATCH][platforms/branch]: Package/Module: Subject

2) The patch email size is large (2MB).  Can you break 
   it up into a patch series.  Perhaps one for the new
   package with its DEC/Includes, one or more for the
   package libraries, one or more for the package modules,
   and one for the package DSC/FDF/platform build files?
   Try to target < 500KB per patch.

   If a patch series is large, another recommendation
   is to also post the patch series to a personal GitHub
   account to support review/test by the community.

3) I see .bat files.  Are there any plans to support
   non windows build environments?

4) If you run BaseTools/Scripts/PatchCheck.py, there
   are 2 minor issues to resolve.

Best regards,

Mike

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to