Hi Laszlo, (1) Yes. There are some fixes. I think you performed the testing on Liming's repository https://github.com/lgao4/edk2/tree/Python3. I am not sure which specific version were you using but we did some fixes in recent days. The repository link(https://github.com/BobCF/edk2.git branch py3basetools) mentioned in this mail have all the patches in Liming's repository, but they are not 1:1 mapping. I merged some patches for they are in same category. (2) Thank you in advance for your more testing.
Thanks, Bob -----Original Message----- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, January 25, 2019 4:57 PM To: Feng, Bob C <bob.c.f...@intel.com> Cc: edk2-devel@lists.01.org; Gao, Liming <liming....@intel.com> Subject: Re: [edk2] [Patch 00/33] BaseTools python3 migration patch set Hi Bob, On 01/25/19 05:55, Feng, Bob C wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=55 > > This patch set is to enable python3 on BaseTools. Basetools code will > be compatible with both python3 and python2. > > We will have two envs PYTHON3_ENABLE and PYTHON_COMMAND. The behavior > can be combined as the below to support this usage. > If user wants the specific python interpreter, he only needs to set > PYTHON_COMMAND env. > If PYTHON3_ENABLE is set, PYTHON_COMMAND will be set to the found one by edk2 > scripts based on PYTHON3_ENABLE value. > If PYTHON3_ENABLE is not set, but PYTHON_COMMAND is set, then PYTHON_COMMAND > will be used to run python script. No version check here. > If PYTHON3_ENABLE is not set, but PYTHON_COMMAND is not set, PYTHON_COMMAND > will be set to the high version python installed in OS. > > This patch set is verified by basic testing on Ovmf, MinKabylake and > MinPurley platform with Python3.7.1 and minimal testing on Ovmf, MinKabylake > and MinPurley with Python2.7.15. > > After this change, we will focus on the Python3 validation. > > You can also review and try the patch set at > https://github.com/BobCF/edk2.git branch py3basetools (1) Have there been any fixes since my last testing at dfc4af35-53e9-ab11-6582-1d0d8e9f2cde@redhat.com">http://mid.mail-archive.com/dfc4af35-53e9-ab11-6582-1d0d8e9f2cde@redhat.com ? (2) My other question would have been about PYTHON3_ENABLE / PYTHON_COMMAND, since we discussed those in the same thread as well. But, your blurb explains them. So the test cases I plan to do are: - Test on RHEL7 (python2 only) without setting any variables. This would be used both for interactive builds and for package builds. - Test on RHEL8 without setting any variables. Expect python3 to be picked automatically. Used for interactive builds. - Test on RHEL8 with just PYTHON_COMMAND set, namely to "/usr/libexec/platform-python". Expect the python3 logic to be active. Would be used for package builds. Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
