On Fri, 25 Jan 2019 at 11:46, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > > On Fri, 25 Jan 2019 at 11:29, Jagadeesh Ujja <jagadeesh.u...@arm.com> wrote: > > > > hi Ard > > > > On Fri, Jan 25, 2019 at 3:32 PM Ard Biesheuvel > > <ard.biesheu...@linaro.org> wrote: > > > > > > On Fri, 25 Jan 2019 at 07:42, Jagadeesh Ujja <jagadeesh.u...@arm.com> > > > wrote: > > > > > > > > Include the HobLib, MmServicesTableLib and MemoryAllocationLib > > > > libraries on > > > > Sgi platforms. These will be consumed by MM_STANDALONE drivers. > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Jagadeesh Ujja <jagadeesh.u...@arm.com> > > > > --- > > > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > index 2a17e9f..65dd6ac 100644 > > > > --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > @@ -71,6 +71,11 @@ > > > > > > > > > > > > StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > > > > > > > > +[LibraryClasses.common.MM_STANDALONE] > > > > + > > > > HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf > > > > + > > > > MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf > > > > + > > > > MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf > > > > + > > > > > > Should you add the entrypoint library as well? > > > > in > > https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > we already have > > StandaloneMmDriverEntryPoint|StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf > > StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > > > > Are you looking for this? > > > > Ah yes, I missed that. > > But in fact, we should replace that reference with the MdePkg version, > and drop the one from StandaloneMmPkg entirely >
For this patch Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Pushed as b4069053a8a6..b0bb325f2033 Thanks! _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
