I agree this proposal. I plan to push python3 patch set to edk2 master in this Friday morning, Feb.1 PRC time if there is no more comments or no critical issues found.
Thanks, Bob -----Original Message----- From: Gao, Liming Sent: Wednesday, January 30, 2019 9:53 AM To: Laszlo Ersek <ler...@redhat.com>; Feng, Bob C <bob.c.f...@intel.com> Cc: edk2-devel@lists.01.org Subject: RE: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set Laszlo: I agree your proposal. Push this patch set first if no other comments, then continue to do minor bug fix. Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, January 29, 2019 9:07 PM > To: Feng, Bob C <bob.c.f...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch > set > > Hi Bob, > > On 01/29/19 03:05, Feng, Bob C wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=55 > > > > V2: > > The python files under CParser4 folder of ECC/Eot tool are generated > > by antlr4 and forpython3 usage. > > They have python3 specific syntax, for example the data type > > declaration for the arguments of a function. That is not compitable > > with python2. this patch is to remove these syntax. > > > > The version2 patch set is commit to > > https://github.com/BobCF/edk2.git branch py3basetools_v2 > > (reusing the "test plan" from my email at > <http://mid.mail-archive.com/cab4fed6-4c5d-94a9-b29f-da41ad7f320e@redh > at.com>:) > > I ran the following tests, at commit 6edb6bd9f182 ("BaseTools: Eot > tool > Python3 adaption", 2019-01-29). Each test was performed in a clean > tree (after running "git clean -ffdx") and clean environment (I > re-sourced "edksetup.sh" for each test in separation). In addition, > the base tools were rebuilt (again from a clean tree) for each test, > with the following command [1]: > > nice make -C "$EDK_TOOLS_PATH" -j $(getconf _NPROCESSORS_ONLN) > > (a) On my RHEL7.5 Workstation laptop, I have both the system-level > python packages installed (python-2.7.5-69.el7_5.x86_64), and the > extra > python-3.4 stuff from EPEL-7 (python34-3.4.9-1.el7.x86_64). > > (a1) Didn't set either PYTHON3_ENABLE or PYTHON_COMMAND. The build > utility picked > > PYTHON_COMMAND = /usr/bin/python3.4 > > and I successfully built OvmfPkg for IA32, IA32X64, and X64; also > ArmVirtQemu for AARCH64. The built firmware images passed a smoke test > too. > > (a2) I removed all the python34 packages (and the dependent packages) > from my laptop. Didn't set either of PYTHON3_ENABLE and PYTHON_COMMAND. > (This is the configuration what a "normal" RHEL7 environment would > provide.) The "build" utility didn't print any PYTHON_COMMAND setting, > but the same fw platform builds as in (a1) completed fine. The smoke > tests passed again as well. > > (b) RHEL-8 virtual machine, with "/usr/bin/python3.6" from > python36-3.6.6-18.el8.x86_64, and "/usr/libexec/platform-python" from > platform-python-3.6.8-1.el8.x86_64. > > (b1) Didn't set either PYTHON3_ENABLE or PYTHON_COMMAND. The build > utility picked > > PYTHON_COMMAND = /usr/bin/python3.6 > > and I successfully built OvmfPkg for IA32, IA32X64, and X64. (I don't > have a cross-compiler installed in this environment yet, nor a RHEL8 > aarch64 KVM guest, so I couldn't test ArmVirtQemu for now). > > (b2) I set PYTHON_COMMAND to "/usr/libexec/platform-python". Didn't > set PYTHON3_ENABLE. The same builds as in (b1) succeeded. > > > For the series: > > Tested-by: Laszlo Ersek <ler...@redhat.com> > > Given that the testing is quite time consuming, I suggest that we push > v2 (assuming reviewers don't find critical issues), and address small > issues incrementally. > > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
