Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, January 29, 2019 10:34 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray <ray...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> > Subject: [PATCH v5 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper > Importance: High > > Substitute InternalShellCharToUpper with a public function > CharToUpper which has the same function. > Remove the implement of InternalShellCharToUpper. > > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jaben Carsey <jaben.car...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > Reviewed-by: Liming Gao <liming....@intel.com> > --- > ShellPkg/Application/Shell/ShellManParser.c | 23 +-------------------- > 1 file changed, 1 insertion(+), 22 deletions(-) > > diff --git a/ShellPkg/Application/Shell/ShellManParser.c > b/ShellPkg/Application/Shell/ShellManParser.c > index b180c6c8f7..2c044dbe4a 100644 > --- a/ShellPkg/Application/Shell/ShellManParser.c > +++ b/ShellPkg/Application/Shell/ShellManParser.c > @@ -46,27 +46,6 @@ SHELL_MAN_HII_VENDOR_DEVICE_PATH > mShellManHiiDevicePath = { > } > }; > > - > -/** > - Convert a Unicode character to upper case only if > - it maps to a valid small-case ASCII character. > - > - This internal function only deal with Unicode character > - which maps to a valid small-case ASCII character, i.e. > - L'a' to L'z'. For other Unicode character, the input character > - is returned directly. > - > - @param Char The character to convert. > - > - @retval LowerCharacter If the Char is with range L'a' to L'z'. > - @retval Unchanged Otherwise. > - > -**/ > -CHAR16 > -InternalShellCharToUpper ( > - IN CHAR16 Char > - ); > - > /** > Verifies that the filename has .EFI on the end. > > @@ -416,7 +395,7 @@ IsTitleHeader( > ReturnFound = TRUE; // This is the desired command's title header > line. > State = (BriefDesc == NULL) ? Final : GetBriefDescription; > } > - else if (InternalShellCharToUpper (*Line) != InternalShellCharToUpper > (*(Command + CommandIndex++))) { > + else if (CharToUpper (*Line) != CharToUpper (*(Command + > CommandIndex++))) { > State = Final; > } > Line++; > -- > 2.18.0.windows.1
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel