On Tue, Feb 12, 2019 at 08:07:52PM +0800, Ming Huang wrote: > >> For D06 library, we use the same source code to support all Hi1620 > >> projects, > >> include product projects,so there are some modify for this, like support > >> 3 sockets, 4 sockets and remove some useless functions. > > > > So please reword the subject line of this commit to explain it is an > > overall update of PlatformSysCtrlLib - including which bits are dropped. > > > > And I think this makes a good argument for moving the header files for > > binary-only libraries from edk2-platforms to edk2-non-osi. > > If you do that in a separate patch before this one, you won't need to > > include as much detail in the commit message as you will otherwise. > > Do youe mean move PlatformSysCtrlLib.h, OemAddressMapLib.h and LpcLib.h to > edk2-non-osi?
Yes. Any interfaces exposed _only_ by implementations in edk2-non-osi. If there are any interfaces _also_ exposed by implementations in edk2-platforms, then I would prefer for them to remain in edk2-platforms. Ideally, this would also include (the multiple) SerdesLib.h, IpmiCmdLib.h, and possibly others. Regards, Leif _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
