Hi,

On 02/13/19 02:42, Shenglei Zhang wrote:
> Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc
> and OvmfPkgX64.dsc.
> Remove content related to UNIXGCC in README.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377
> 
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
> Cc: Anthony Perard <anthony.per...@citrix.com>
> Cc: Julien Grall <julien.gr...@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com>
> Reviewed-by: Laszlo Ersek <ler...@redhat.com>
> ---
>  OvmfPkg/OvmfPkgIa32.dsc    |  1 -
>  OvmfPkg/OvmfPkgIa32X64.dsc |  1 -
>  OvmfPkg/OvmfPkgX64.dsc     |  1 -
>  OvmfPkg/README             | 19 -------------------
>  4 files changed, 22 deletions(-)

You forgot to pick up Ard's Acked-by:

  [edk2] [PATCH v2 05/10] OvmfPkg/README: Remove UNIXGCC
  https://lists.01.org/pipermail/edk2-devel/2019-February/036486.html

Please amend the commit message before pushing the series.

Thanks
Laszlo

> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index 2b642ab5dc..f9216af479 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -62,7 +62,6 @@
>  !endif
>  
>  [BuildOptions]
> -  GCC:*_UNIXGCC_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    GCC:RELEASE_*_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    INTEL:RELEASE_*_*_CC_FLAGS           = /D MDEPKG_NDEBUG
>    MSFT:RELEASE_*_*_CC_FLAGS            = /D MDEPKG_NDEBUG
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index 14a5c1bb29..1e470de744 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -62,7 +62,6 @@
>  !endif
>  
>  [BuildOptions]
> -  GCC:*_UNIXGCC_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    GCC:RELEASE_*_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    INTEL:RELEASE_*_*_CC_FLAGS           = /D MDEPKG_NDEBUG
>    MSFT:RELEASE_*_*_CC_FLAGS            = /D MDEPKG_NDEBUG
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index aa7197f533..e4929d8cf4 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -62,7 +62,6 @@
>  !endif
>  
>  [BuildOptions]
> -  GCC:*_UNIXGCC_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    GCC:RELEASE_*_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    INTEL:RELEASE_*_*_CC_FLAGS           = /D MDEPKG_NDEBUG
>    MSFT:RELEASE_*_*_CC_FLAGS            = /D MDEPKG_NDEBUG
> diff --git a/OvmfPkg/README b/OvmfPkg/README
> index 68ce0750af..c014d07bfb 100644
> --- a/OvmfPkg/README
> +++ b/OvmfPkg/README
> @@ -402,25 +402,6 @@ main firmware (MAINFV) into RAM memory at address 
> 0x800000. The
>  remaining OVMF firmware then uses this decompressed firmware
>  volume image.
>  
> -=== UNIXGCC Debug ===
> -
> -If you build with the UNIXGCC toolchain, then debugging will be disabled
> -due to larger image sizes being produced by the UNIXGCC toolchain. The
> -first choice recommendation is to use GCC48 or newer instead.
> -
> -If you must use UNIXGCC, then you can override the build options for
> -particular libraries and modules in the .dsc to re-enable debugging
> -selectively. For example:
> -  [Components]
> -  OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf {
> -    <BuildOptions>
> -      GCC:*_*_*_CC_FLAGS             = -UMDEPKG_NDEBUG
> -  }
> -  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf {
> -    <BuildOptions>
> -      GCC:*_*_*_CC_FLAGS             = -UMDEPKG_NDEBUG
> -  }
> -
>  === UEFI Windows 7 & Windows 2008 Server ===
>  
>  * One of the '-vga std' and '-vga qxl' QEMU options should be used.
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to