Reviewed-by: Liming Gao <liming....@intel.com> >-----Original Message----- >From: Feng, Bob C >Sent: Tuesday, February 19, 2019 9:30 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com> >Subject: [Patch] BaseTools: Fix a bug about Structure PCD > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1535 >If there is Hii Structure Pcd, build will fail, root cause is that >there is an incorrect variable access method used in code. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Bob Feng <bob.c.f...@intel.com> >Cc: Liming Gao <liming....@intel.com> >--- > BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py >b/BaseTools/Source/Python/Workspace/DscBuildData.py >index e45beb3924..2e6eb16b08 100644 >--- a/BaseTools/Source/Python/Workspace/DscBuildData.py >+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py >@@ -2392,11 +2392,11 @@ class DscBuildData(PlatformBuildClassObject): > skuinfo = Pcd.SkuInfoList[skuname] > if skuinfo.VariableName: > for defaultstore in skuinfo.DefaultStoreDict: > pcddscrawdefaultvalue = > self.GetPcdDscRawDefaultValue(Pcd, >skuname, defaultstore) > if pcddscrawdefaultvalue: >- Value = skuinfo[defaultstore] >+ Value = skuinfo.DefaultStoreDict[defaultstore] > if "{CODE(" in Value: > realvalue = Value.strip()[6:-2] # > "{CODE(").rstrip(")}" > CApp += "static %s %s_%s_%s_%s_Value%s = > %s;\n" % >(Pcd.BaseDatumType,Pcd.TokenSpaceGuidCName,Pcd.TokenCName,skunam >e,defaultstore,Demesion,realvalue) > else: > pcddscrawdefaultvalue = self.GetPcdDscRawDefaultValue(Pcd, >skuname, TAB_DEFAULT_STORES_DEFAULT) >-- >2.20.1.windows.1
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
