Rebecca,
On 02/26/19 00:56, Gao, Liming wrote:
> Yes. This is a bug fix. I agree to push it for Q1 release.
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Tuesday, February 26, 2019 3:36 AM
>> To: Gao, Liming <liming....@intel.com>; Rebecca Cran
>> <rebe...@bluestop.org>; edk2-devel@lists.01.org
>> Cc: Kinney, Michael D <michael.d.kin...@intel.com>
>> Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow,
>> outdated sourceforge git mirror
>>
>> On 02/25/19 14:36, Gao, Liming wrote:
>>> I can't clone edk2 code from http://git.code.sf.net/p/tianocore/edk2.
>> Seemly, it doesn't work. So, I agree to remove it.
>>>
>>> Reviewed-by: Liming Gao <liming....@intel.com>
>>
>> Do we consider this a bugfix, suitable to be pushed during the soft
>> feature freeze?
>>
>> I suggest that we do.
I've tried applying this patch, and found two issues.
First, you didn't add:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran <rebe...@bluestop.org>
Second, this patch is based on a very outdated state of the edk2 tree. I
have to apply it on top of commit 2d4fd226da42 ("BaseTools GenFw: Fix
XCODE5 build issue", 2019-01-15); otherwise it doesn't apply. It runs
into a conflict with commit 1f7b74831544 ("Maintainers.txt: Update mail
address", 2019-01-15).
I could fix issue #2 with a rebase myself; however, issue #1 has to be
fixed by you. Please post a v3, addressing both issues, and also picking
up the feedback tags that you received in this thread (from Liming and
myself).
Thanks,
Laszlo
>>>> -----Original Message-----
>>>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>> Laszlo Ersek
>>>> Sent: Monday, February 25, 2019 6:07 PM
>>>> To: Rebecca Cran <rebe...@bluestop.org>; edk2-devel@lists.01.org
>>>> Cc: Kinney, Michael D <michael.d.kin...@intel.com>
>>>> Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow,
>> outdated sourceforge git mirror
>>>>
>>>> On 02/23/19 06:18, Rebecca Cran via edk2-devel wrote:
>>>>> ---
>>>>> Maintainers.txt | 7 +++----
>>>>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/Maintainers.txt b/Maintainers.txt
>>>>> index 7f1061d6c1..d9d3d840c5 100644
>>>>> --- a/Maintainers.txt
>>>>> +++ b/Maintainers.txt
>>>>> @@ -31,11 +31,10 @@ Descriptions of section entries:
>>>>>
>>>>> EDK II
>>>>> ------
>>>>> -W: http://www.tianocore.org/edk2/
>>>>> -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
>>>>> +W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
>>>>> +L: https://lists.01.org/mailman/listinfo/edk2-devel
>>>>> T: git - https://github.com/tianocore/edk2.git
>>>>> T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
>>>>> -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
>>>>> T: svn (read-only, deprecated) -
>> https://svn.code.sf.net/p/edk2/code/trunk/edk2
>>>>>
>>>>> Tianocore Stewards
>>>>> @@ -203,7 +202,7 @@ W:
>> https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg
>>>>> M: Ruiyu Ni <ruiyu...@intel.com>
>>>>>
>>>>> OvmfPkg
>>>>> -W: http://www.tianocore.org/ovmf/
>>>>> +W: https://github.com/tianocore/tianocore.github.io/wiki/OVMF
>>>>> M: Jordan Justen <jordan.l.jus...@intel.com>
>>>>> M: Laszlo Ersek <ler...@redhat.com>
>>>>> M: Ard Biesheuvel <ard.biesheu...@linaro.org>
>>>>>
>>>>
>>>> Reviewed-by: Laszlo Ersek <ler...@redhat.com>
>>>>
>>>> I can help push this change, but first let's wait for more feedback. I
>>>> think the only point that might see a bit of discussion is dropping
>>>> <git.code.sf.net> (as you highlight in your followup).
>>>>
>>>> Thanks!
>>>> Laszlo
>>
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
