On Wed, Mar 06, 2019 at 04:17:51PM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 16:16, Achin Gupta <achin.gu...@arm.com> wrote: > > > > Hi Ard, > > > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > > > first place since the value is implied by the context (it is never > > > valid to set it to FALSE for standalone MM or TRUE for traditional > > > MM). So drop it. > > > > This is being used to determine if the ArmVExpressPkg should include > > support for > > StMM comm. buffer or not [1] but it does look redundant now. > > > > If that is the case, the PCD should be defined in that package.
The Arm FVP port for StMM needs a rewrite on the lines of other platforms. This change is fine. Reviewed-by: achin.gu...@arm.com _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
