On Mon, 11 Mar 2019 at 14:56, Thomas Abraham <thomas.abra...@arm.com> wrote: > > On Mon, Mar 11, 2019 at 7:09 PM Ard Biesheuvel > <ard.biesheu...@linaro.org> wrote: > > > > On Mon, 11 Mar 2019 at 14:31, Thomas Abraham <thomas.abra...@arm.com> wrote: > > > > > > On Fri, Mar 8, 2019 at 9:01 PM Ard Biesheuvel <ard.biesheu...@linaro.org> > > > wrote: > > > > > > > > Bring SgiPkg in line with EDK2 core changes to StandaloneMmPkg: > > > > - add a resolution for ExtractGuidedSectionLib > > > > - remove reference to > > > > gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable > > > > - update the resolution of StandaloneMmDriverEntryPoint > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > > > --- > > > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 8 ++++---- > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > index 65dd6ac82c4a..ef16bfa9a20e 100644 > > > > --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > @@ -43,6 +43,7 @@ > > > > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > > > > > > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > > > > > > > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > > > > + > > > > ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf > > > > > > The build fails with the following error > > > > > > /home/thopan01/devel/sgi/sgi-dev/uefi/edk2/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c:37: > > > undefined reference to `memcpy' > > > /tmp/ccOj5Ie6.ltrans0.ltrans.o: In function > > > `ExtractGuidedSectionLibConstructor': > > > /home/thopan01/devel/sgi/sgi-dev/uefi/edk2/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c:233: > > > undefined reference to `memcpy' > > > collect2: error: ld returned 1 exit status > > > > > > I will check further why the build fails here. > > > > > > > We need to add this in the .dsc > > > > # > > # It is not possible to prevent the ARM compiler for generic > > intrinsic functions. > > # This library provides the instrinsic functions generate by a given > > compiler. > > # And NULL mean link this library into all ARM images. > > # > > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > Thanks, it works with this change. So with this change rolled into this patch. > Reviewed-by: Thomas Abraham <thomas.abra...@arm.com>
Thanks Thomas Pushed as c63c3f071271..68cc99303e38 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
