On 03/21/19 13:04, Lars Kurth wrote: > > > On 20/03/2019, 18:25, "Laszlo Ersek" <ler...@redhat.com> wrote: > > But, again, this should be discussed in that separate BZ then. > > > > OvmfPkg/XenBusDxe/XenBus.c > > This file is licensed under the BSD license, aka > https://opensource.org/licenses/bsd-license.php > > > > OvmfPkg/XenBusDxe/XenStore.c > > > OvmfPkg/XenBusDxe/XenStore.h > >I do not know where these files come from. The files do not appear to > come from a Xen project repo. > > See commit a9090a94bb4a ("OvmfPkg/XenBusDxe: Add XenStore client > implementation", 2014-10-29), by Anthony. > > https://github.com/tianocore/edk2/commit/a9090a94bb4a > > The commit message states, > > >Origin: FreeBSD 10.0 > >License: This patch adds several files under the MIT licence. > > >So, unless you trust that the license in the headers are correct, the > right thing would be to identify the source and check whether the license > text has been imported unmodified > > We do trust that the license blocks, as they exist, are correct. Where > we need help & support is the mapping/replacement of those verbose > license blocks to/with SPDX-License-Identifier tags. > > As I now understand what is needed, I had a look at the XenStore.* licenses. > They are NOT a standard MIT license > > The sources say: > "Permission is hereby granted, free of charge, to any person obtaining a copy > of this source file (the "Software")" > The MIT license says > "Permission is hereby granted, free of charge, to any person obtaining a copy > of this software and associated documentation files (the "Software")" > > I would argue that replacing "source file" with "software and associated > documentation files" is probably OK, but I am not an expert. I am pretty sure > this type of issue has come up before when migrating to SPDX. It might be > worthwhile reaching out to someone from SPDX. > > Hope this helped
Thank you! We'll revisit this issue (and thread, I assume) later on. Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
