On 03/21/19 15:04, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 > > Add new APIs' implementation (DebugVPrint, DebugBPrint) > in the DebugLib instance. These APIs would expose print > routines with VaList parameter and BaseList parameter. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao <[email protected]> > Cc: Jordan Justen <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Cc: Ard Biesheuvel <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Sean Brogan <[email protected]> > Cc: Michael Turner <[email protected]> > Cc: Bret Barkelew <[email protected]> > --- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 106 > +++++++++++++++++++++- > 1 file changed, 101 insertions(+), 5 deletions(-)
This v4 patch is identical to v3. When you repost a series in order to update a subset of the patches, you should please pick up the feedback tags from the previous review session for those patches that you do *not* change. This is explained here, for example: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-26 https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-28 This makes a huge difference for reviewers -- it costs you a bit of time, but it saves reviewers a lot more time. For example, the present patch has not been changed from v3 to v4, and I gave my A-b in the v3 review session. Therefore you should have edited the commit message on this patch, to include my A-b, for the v4 posting. Either way, I can give it again here. Acked-by: Laszlo Ersek <[email protected]> Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
