Hi Sami, On the whole, this set looks fine - but: - could you go through and sort the #include files alphabetically in .c/.h (within each grouping)? - similarly, could you go through and ensure that .inf files contain alphabetically sorted [Sources], [Packages] and [LibraryClasses] sections? (The [*Pcd] sections are fine the way they are.) - Up to you, but if you would prefer to squash the set of minor updates into a v2 of this, I'd be OK with that.
Best Regards, Leif On Thu, Jan 24, 2019 at 03:46:52PM +0000, Sami Mujawar wrote: > Dynamic Tables Framework aims to reduce the amount of effort > required for porting firmware to new platforms by simplifying > the generation of firmware tables based on hardware description > provided by a platform specific component. > > The Dynamic Tables Framework core queries the platform specific > component to retrieve the required hardware information for > generating standardised firmware tables at run-time. > > The platform specific component responsible for collating the > hardware information is called the Configuration Manager. > > This patch series introduce the Configuration Manager that > provides the hardware description to Dynamic Tables Framework. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar <sami.muja...@arm.com> > > The changes can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/365_dynamic_tables_framework_v3 > > This v3 patch series incorporates: > * updates corresponding to the dynamic tables framework's change > to support the newer versions of specifications. > * support for describing the platform GT Block timers on Juno. > * minor code improvements. > > The corresponding edk2 code changes can be seen at: > https://github.com/samimujawar/edk2/tree/365_dynamic_tables_framework_v2 > > Sami Mujawar (4): > Platform/ARM: Configuration Manager for Juno > Platform/ARM: Dynamic Tables support for Juno > Platform/ARM: Configuration Manager for FVP > Platform/ARM: Dynamic Tables support for FVP > > Platform/ARM/JunoPkg/ArmJuno.dsc > | 12 +- > Platform/ARM/JunoPkg/ArmJuno.fdf > | 12 + > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc > | 29 + > > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > | 752 ++++++++++++++++++++ > > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > | 179 +++++ > > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > | 86 +++ > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Platform.h > | 99 +++ > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > | 276 +++++++ > > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf > | 45 ++ > > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtJunoUsb.asl > | 123 ++++ > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtPci.asl > | 201 ++++++ > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtUart.asl > | 48 ++ > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > | 9 +- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > | 15 + > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf > | 16 +- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc > | 31 + > > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > | 684 ++++++++++++++++++ > > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > | 181 +++++ > > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > | 79 ++ > > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Platform.h > | 99 +++ > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > | 73 ++ > > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf > | 35 + > 22 files changed, 3079 insertions(+), 5 deletions(-) > create mode 100644 > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc > create mode 100644 > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > create mode 100644 > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > create mode 100644 > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > create mode 100644 > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Platform.h > create mode 100644 > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > create mode 100644 > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf > create mode 100644 > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtJunoUsb.asl > create mode 100644 > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtPci.asl > create mode 100644 > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/SsdtUart.asl > create mode 100644 > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc > create mode 100644 > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > create mode 100644 > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > create mode 100644 > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > create mode 100644 > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Platform.h > create mode 100644 > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > create mode 100644 > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
