On 03/25/19 18:30, Kinney, Michael D wrote: > Hi Laszlo, > > I do not think content added before April 9, 2019 > should use the new license type. We need to let the > 30-day review period complete and make sure all feedback > is resolved.
Good point. > We will handle files added between the edk2-stable201903 > and April 9, 2019 in a final patch series with an easy > way for all maintainers to see what has changed between > those two points. Hm. From the reviewer side, this is not optimal. The patch set (and the individual patches themselves) are pretty big, and doing incremental reviews on them is taxing. Regardless of whether the incremental review needs to target an updated "full" patch set, or just an incremental patch set (for new files), the reviewer needs to re-evaluate whether something is now missed, after the introduction of new files. Instead, I'd prefer a "lock" period for OvmfPkg and ArmVirtPkg, between (a) my next (hopefully, final) review for the license conversion patches, and (b) the pushing of those patches. For that, I see two options: - We could delay Hao's work (and all other patches that add files to OvmfPkg and ArmVirtPkg files) until after April 9. We can of course collaborate on feature / bugfix patches meanwhile, it's just that the final versions of *those* should be reposted with updated license blocks. Incrementally reviewing *those* changes feels a lot easier to me. - Alternatively, I could delay my next (hopefully, final) review of the license conversion patches until reasonably close to April 9, until which "review point" new files could be added freely, to OvmfPkg and ArmVirtPkg. (This wouldn't eliminate the "lock period", just make it shorter for contributors.) IOW, this is similar to the stabilization period / feature freezes, just much more intrusive, because everything has to be switched at the same moment. I'd like to reach an understanding on our approach before I start reviewing "[edk2] [PATCH V2] Change EDK II to BSD+Patent License". Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
