> -----Original Message----- > From: Laszlo Ersek [mailto:[email protected]] > Sent: Wednesday, March 27, 2019 11:37 AM > To: Wu, Hao A > Cc: Anthony PERARD; Justen, Jordan L; [email protected]; Julien Grall > Subject: Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within > IntelFrameworkModulePkg > > On 03/27/19 01:20, Wu, Hao A wrote: > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:[email protected]] > >> Sent: Tuesday, March 26, 2019 11:15 PM > >> To: Wu, Hao A > >> Cc: Anthony PERARD; Justen, Jordan L; [email protected]; Julien Grall > >> Subject: Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within > >> IntelFrameworkModulePkg > >> > >> Hi Hao, > >> > >> On 03/26/19 16:01, Laszlo Ersek wrote: > >>> On 03/26/19 14:03, Anthony PERARD wrote: > >>>> On Mon, Mar 25, 2019 at 12:29:25PM +0100, Laszlo Ersek wrote: > >>>>> (4) Julien, Anthony: can you please fetch this series (github URL at the > >>>>> top) and see if the PS/2 keyboard, and the serial port, still work on > >>>>> Xen, to interact e.g. with the UEFI shell? > >>>> > >>>> Yes, I can still interact with the UEFI shell with this series applied, > >>>> both via the console and via VNC (which uses respectively the serial > >>>> port and PS/2 I think). > >>> > >>> Thank you -- can you please follow up with a Tested-by, or do you prefer > >>> if I push the set without it? > >> > >> ... actually, I just realize that you can push this series just fine, > >> after Anthony's answer -- so please excuse my confusing comment; I'll of > >> course let you push the series. > > > > Hello Laszlo, > > > > Sure, I will push the series. > > > > But one thing to confirm, for patch 2/3, it only got a couple of 'Ack' > > tags and a 'Tested-by' tag. I am not sure if this meets the criteria for > > pushing. > > Yes, if you get an Acked-by from at least one "M" person for the package > (and no open questions remain), that's sufficient. For edk2, my > interpretation of "Acked-by" is: "although I haven't reviewed in detail, > I agree/approve".
Got it. Thanks all for the feedbacks and review/test effort. Series has been pushed via commits: c455bc8c8d..a068102296 Best Regards, Hao Wu > > Thanks, > Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
