On 04/03/19 09:00, Hao Wu wrote: > This series is also available at: > https://github.com/hwu25/edk2/tree/ovmf_8259_8254_rfcv1 > > > As a sub-task to remove the IntelFrameworkPkg (BZ-1604), > > 8259InterruptControllerDxe driver (PcAtChipsetPkg) > Legacy8259 protocol (IntelFrameworkPkg) > 8254TimerDxe driver (PcAtChipsetPkg) > > will be removed in the near future. Meanwhile, OVMF will still require > those components (due to CSM support & HPET emulation stability concern). > > Thus, the series will copy the below 8259/8254 components: > > A. 8259InterruptControllerDxe driver (PcAtChipsetPkg) > B. Two 8259 related PCDs (PcAtChipsetPkg) > C. Legacy8259 protocol (IntelFrameworkPkg) > D. 8254TimerDxe driver (PcAtChipsetPkg) > > in the OvmfPkg to address the above-mentioned issue. > > > Tests done for the proposed series: > > A. OvmfPkg build pass for VS2015 & GCC5 tool chains; > B. Boot to Shell with commands: > qemu-system-x86_64.exe -pflash <SOME_PATH>\OVMF.fd -debugcon file:boot.log > -global isa-debugcon.iobase=0x402 > qemu-system-x86_64.exe -machine q35 -pflash <SOME_PATH>\OVMF.fd -debugcon > file:boot.log -global isa-debugcon.iobase=0x402 > C. 'stall X' command under Shell to verify the timer is working properly. > > > (Please note that there will be a subsequent patch to remove the 8259/8254 > components after platforms dropping the dependencies on them.) > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: David Woodhouse <dw...@infradead.org> > Cc: Ray Ni <ray...@intel.com> > > > Hao Wu (8): > OvmfPkg: Copy 8259InterruptControllerDxe driver from PcAtChipsetPkg > OvmfPkg: Copy Legacy8259 protocol definitions from IntelFrameworkPkg > OvmfPkg/OvmfPkg.dec: Add 8259-related PCDs in OVMF DEC file > OvmfPkg/8259InterruptControllerDxe: Update to make it build for OVMF > OvmfPkg/AcpiPlatformDxe: Consume the 8259 PCD defined in OvmfPkg > OvmfPkg: Copy 8254TimerDxe driver from PcAtChipsetPkg > OvmfPkg/8254TimerDxe: Update to make it build for OVMF > OvmfPkg: Update DSC/FDF files to consume 8259/8254 drivers in OvmfPkg
While I'm reviewing the patches individually, let me make some general comments: - please don't push the series before April 9th (i.e., before the end of the file addition/removal freeze due to <https://bugzilla.tianocore.org/show_bug.cgi?id=1373>) - if/when you push the series, please make sure that *all* files added (copied) under OvmfPkg get the new license block format, i.e. the SPDX license identifier only. Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
