Dear MdeModulePkg maintainers,
Correct please the error
--------------
/Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1458:47:
error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]
} else if ((InputString[*Index + StrOffset] == CHAR_LINEFEED)) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
/Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1458:47:
note: remove extraneous parentheses around the comparison to silence this
warning
} else if ((InputString[*Index + StrOffset] == CHAR_LINEFEED)) {
~ ^ ~
/Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1458:47:
note: use '=' to turn this equality comparison into an assignment
} else if ((InputString[*Index + StrOffset] == CHAR_LINEFEED)) {
^~
=
/Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1467:47:
error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]
} else if ((InputString[*Index + StrOffset] == CHAR_CARRIAGE_RETURN)) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1467:47:
note: remove extraneous parentheses around the comparison to silence this
warning
} else if ((InputString[*Index + StrOffset] == CHAR_CARRIAGE_RETURN)) {
~ ^ ~
/Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1467:47:
note: use '=' to turn this equality comparison into an assignment
} else if ((InputString[*Index + StrOffset] == CHAR_CARRIAGE_RETURN)) {
^~
--------------
As far as I understand we just have to remove double braces.
Sergey
------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel