Sathya, Add my comments below
Thanks, Eric -----Original Message----- From: Prakash, Sathya [mailto:sathya.prak...@lsi.com] Sent: Tuesday, October 02, 2012 7:18 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] What is expected in Progress parameter of ConfigAccess.RouteConfig. All, The spec says the Progress parameter of the EFI_HII_CONFIG_ACCESS_PROTOCOL.RouteConfig() as a pointer to a string filled in with the offset of the most recent '&' before the first failing name / value pair (or the beginning of the string if the failure is in the first name / value pair) or the terminating NULL if all was successful. And in my driver I have some error checks way before calling EFI_HII_CONFIG_ROUTING_PROTOCOL.ConfigToBlock() (which actually fills in the Progress string as of now) in those error checks if there is some error what I should return in the Progress string. [[Eric]] In this case, I think you should return all of the input Configuration, because you not save any data. Similarly after the ConfigtoBlock(), I try to apply the data received on RouteConfig in my hardware, before that I have series of validation and if any of the validation fails what I should return in the Progress String, (If so Progress string should be deallocated?). [[Eric]] In this case, I think you should return all of the input Configuration, because you not save any data. Is the whole Progress String is only used for errors detected while parsing the input through ConfigToBlock or for handling other errors too?. If it is not for other errors, can I set it point to Null character of ConfigResp String always except for ConfigToBlock? If it should be set for others, is there a function to provide the offset in the block data and get the corresponding one from ConfigResp. [[Eric]] I think it can handle other error, but the browser only care the save action. It base on the Progress value to check how much data do you have saved. Not have the function meet your request. Also I am concerned about whether we need to set the offset, or the substring of configresp starting from offset in the Progress string. [[Eric]] what is this used for? The config access definition is as below A pointer to a string filled in with the offset of the most recent '&' before the first failing name / value pair (or the beginning of the string if the failure is in the first name / value pair) or the terminating NULL if all was successful. The ConfigToBlock definition is as below On return, points to an element of the ConfigResp string filled in with the offset of the most recent '&' before the first failing name / value pair (or the beginning of the string if the failure is in the first name / value pair) or the terminating NULL if all was successful. Thanks Sathya ------------------------------------------------------------------------------ Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
