Olivier,
Thanks for your patch. Though I don't quite agree with you that SnpMode cannot
be accessed prior to SNP is configured.
As I known some parameters in SnpMode will be initialized in
SimpleNetworkDriverStart() by calling undi.GetInitInfo. These parameters will
not be updated by other APIs in SNP protocol including SNP->initialize. One of
these parameters is 'IfType' used in ARP driver from your patch. Thus I think
it makes sense that upper layer driver uses this kind of info prior to
configure SNP to save performance lost in some conditions.
Best Regards,
Ting
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Friday, January 25, 2013 9:07 PM
To: Tian, Feng
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] MdeModulePkg/ArpDxe: Retrieved SnpMode only after
configuring Snp
Dear MdeModulePkg maintainer,
Please find the attached patch that retrieved SnpMode only after configuring
Snp.
When Arp driver starts (with ArpDriverBindingStart()), its service will be
created
and the Mnp child configured (ArpService->Mnp->Configure() called in
ArpCreateService()).
It is only at this time the Snp protocol will be initialized (at the end of
MnpStart()).
So, a valid SnpMode could not be expected prior to ArpService->Mnp->Configure().
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin
<olivier.mar...@arm.com<mailto:olivier.mar...@arm.com>>
Best Regards,
Olivier
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
