Thanks Eric,
Both were my code issues and I am able to fix them. The prompt is not displayed 
because I didn't get the SetString function will return the new string ID for 
unallocated strings and the second one is due to the reason that I have not 
passed EndOpCodeHandle for HiiUpdateForm.

-Sathya


-----Original Message-----
From: Tim Lewis [mailto:[email protected]] 
Sent: Tuesday, February 19, 2013 11:27 PM
To: [email protected]
Subject: Re: [edk2] Dyanamic primitive creation

Eric --

Do you think it is good practice to modify a form that is already open? Using 
UpdateForm() in the method you describe seems unusual, since there is no 
documented behavior about how the Form Browser should handle this behavior. I 
know it is done often, but using undefined behavior in a driver meant to show 
sample behavior doesn't seem like a behavior. 

It seems that this sample is using a lot of non-UEFI features, including custom 
opcodes. It seems it would be better to focus on standard usage. 

Tim

-----Original Message-----
From: Dong, Eric [mailto:[email protected]]
Sent: Tuesday, February 19, 2013 9:45 PM
To: [email protected]
Subject: Re: [edk2] Dyanamic primitive creation

Sathya,

Add my comments below.

Thanks,
Eric

-----Original Message-----
From: Prakash, Sathya [mailto:[email protected]]
Sent: Wednesday, February 20, 2013 12:18 AM
To: [email protected]
Subject: [edk2] Dyanamic primitive creation

I am trying to create dynamic primitives in a form, the calls were successful 
and I am able to see the one of values, but the string I am using for the 
question prompt are not displayed (I am dynamically setting those strings). 
[[Eric]] I'm not clear how your code is written, but we have an example in 
DriverSampleDxe, in the DriverCallback function, in the 
EFI_BROWSER_ACTION_FORM_OPEN case for QuestionId == 0x1234, we will insert 
action op code in the form, you can refer it. If still has problem, can you 
help to attach you code and we can find where the error is?

Also I did see whenever I enters into the form, the dynamic primitives are 
getting appended and the list keeps growing, I am not aware of how to clear or 
remove the primitives from existing form. Any help?
[[Eric]] we have two methods to add new op code, 
        #1 adds new op code after the label, so every time new op code is added 
and old op code still there, example like the above code for question 1.
        #2 replaces the code between two labels, so every time only new op code 
shows, the old code between these two labels will be replaced. Example shows in 
DriverCallback function, EFI_BROWSER_ACTION_CHANGING case, when QuestionId == 
0x1234.

Thanks
Sathya

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics Download AppDynamics Lite for free 
today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics Download AppDynamics Lite for free 
today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics Download AppDynamics Lite for free 
today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to