Sorry, the signed-off was for the patch I attached to my email. I reviewed your patch and it is correct. But the patch I did (and sent to a separate email) should be linked with your patch to avoid the potential 'multiple symbol with the same name' link error that could cause your patch.
Thanks, Olivier > -----Original Message----- > From: Jordan Justen [mailto:[email protected]] > Sent: 13 May 2013 23:02 > To: [email protected] > Subject: Re: [edk2] [PATCH] EmulatorPkg: Add SerialPortExtLib library > class mapping > > On Mon, May 13, 2013 at 1:32 PM, Olivier Martin > <[email protected]> wrote: > > And also > > This patch was Reviewed-by you? > > > apply the related changes of the attached patch. > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Olivier Martin <[email protected]> > > Can you post this as a separate patch with a commit message? > (...preferably using git send-email.) > > Thanks, > > -Jordan > > >> -----Original Message----- > >> From: Jordan Justen [mailto:[email protected]] > >> Sent: 10 May 2013 04:08 > >> To: [email protected] > >> Subject: [edk2] [PATCH] EmulatorPkg: Add SerialPortExtLib library > class > >> mapping > >> > >> Contributed-under: TianoCore Contribution Agreement 1.0 > >> Signed-off-by: Jordan Justen <[email protected]> > >> --- > >> EmulatorPkg/EmulatorPkg.dsc | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/EmulatorPkg/EmulatorPkg.dsc > b/EmulatorPkg/EmulatorPkg.dsc > >> index 1c71269..ae318bd 100644 > >> --- a/EmulatorPkg/EmulatorPkg.dsc > >> +++ b/EmulatorPkg/EmulatorPkg.dsc > >> @@ -86,6 +86,7 @@ > >> > >> > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/Dxe > >> SecurityManagementLib.inf > >> > >> > TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTempla > >> te.inf > >> > >> > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNul > >> l.inf > >> + > >> > SerialPortExtLib|EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateS > >> erialPortExtLib.inf > >> > >> > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > >> # > >> # Platform > >> -- > >> 1.7.10.4 > >> > >> > >> -------------------------------------------------------------------- > --- > >> ------- > >> Learn Graph Databases - Download FREE O'Reilly Book > >> "Graph Databases" is the definitive new guide to graph databases and > >> their applications. This 200-page book is written by three acclaimed > >> leaders in the field. The early access version is available now. > >> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may > >> _______________________________________________ > >> edk2-devel mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > > --------------------------------------------------------------------- > --------- > > AlienVault Unified Security Management (USM) platform delivers > complete > > security visibility with the essential security capabilities. Easily > and > > efficiently configure, manage, and operate all of your security > controls > > from a single console and one unified framework. Download a free > trial. > > http://p.sf.net/sfu/alienvault_d2d > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > > ----------------------------------------------------------------------- > ------- > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily > and > efficiently configure, manage, and operate all of your security > controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
