Alex,

The macro/function cannot go in the middle of the variable declarations.  What 
do you think of this?

-Jaben

-----Original Message-----
From: Alexei Fedorov [mailto:[email protected]] 
Sent: Monday, July 29, 2013 5:57 AM
To: [email protected]
Subject: [edk2] InternalShellProtocolDebugPrintMessage() returns un-initialised 
Status

1. InternalShellProtocolDebugPrintMessage() function in 
\edk2\ShellPkg\Application\Shell\ShellProtocol.c returns un-initialised Status 
variable:
EFI_STATUS
EFIAPI
InternalShellProtocolDebugPrintMessage (
  IN CONST CHAR16                   *Mapping,
  IN CONST EFI_DEVICE_PATH_PROTOCOL *DevicePath
  )
{
  EFI_STATUS                        Status;
  CHAR16                            *Temp;
  DEBUG_CODE_BEGIN();
  if (Mapping != NULL) {
    DEBUG((EFI_D_INFO, "Added new map item:\"%S\"\r\n", Mapping));
  }
  Temp = ConvertDevicePathToText(DevicePath, TRUE, TRUE);
  DEBUG((EFI_D_INFO, "DevicePath: %S\r\n", Temp));
  FreePool(Temp);
  DEBUG_CODE_END();
  return (Status);
}
2. DEBUG_CODE_BEGIN() macro should be placed before *Temp declaration to 
suppress warning regarding unused variable for RELEASE build.


-- IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium.  Thank you.


------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics Get end-to-end 
visibility with application monitoring from AppDynamics Isolate bottlenecks and 
diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Attachment: ShellProtocol.c.patch
Description: ShellProtocol.c.patch

------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent 
caught up. So what steps can you take to put your SQL databases under 
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to