On 09/22/13 01:52, Jordan Justen wrote:
> On Sat, Sep 21, 2013 at 8:08 AM, Laszlo Ersek <[email protected]> wrote:
>> For what it's worth, I committed the attached patch on top of this
>> series. This accelerates the OVMF startup on SVM to be on par with the
>> VMX experience. However, I'm not sure if it's *safe* to enable caching
>> that early!
>>
>> Until we figure this all out, I think the slower startup on AMD should
>> not be a problem; the series is strictly an improvement on AMD too.
>
> I think your patch is a good change, and I want to add it to the
> middle of my series with this expanded commit message:
>
> OvmfPkg/ResetVector: enable caching in initial page tables
>
> In UEFI X64 we use other mechanisms to disable caching.
> (CD/NW in CR0 and MTRRs.)
>
> This fixes a slow boot issue with SVM.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <[email protected]>
> Reviewed-by: Jordan Justen <[email protected]>
Thanks! :)
Please do save your name in the signoff block, maybe in the usual
"bracketed small fixup" format; the commit message is important and it
does explain stuff that I had no idea about.
(BTW I continued to play with OVMF on my AMD machine for the rest of
today, with your series (+ my addition) applied. Very good results;
secure boot with F19, qemu boot order, PXE booting with VirtioNetDxe,
ping from the UEFI shell, all work. Attaching my qemu wrapper script for
posterity, this time without libvirt...)
Thanks!
Laszlo
#!/bin/bash
BI_HD=0
BI_CD=1
BI_NET=2
GUEST=ld2g
QPATH=$HOME/installed/qemu
CD=$HOME/Fedora-Live-XFCE-x86_64-19-1.iso
SOCK=$HOME/$GUEST.ttyS0
HOSTIP=192.168.2.2
HOSTFWDP=7777
{
printf "Issue the following command to connect to the serial port:\\n"
printf "minicom -o -D 'unix#%s'\\n" "$SOCK"
printf "\\n"
printf "The following command connects to the graphical console:\\n"
printf "vncviewer %s:0\\n" $HOSTIP
printf "\\n"
printf "Ssh access:\\n"
printf "ssh -o UserKnownHostsFile=/dev/null \\\\\\n"
printf " -o StrictHostKeyChecking=no -X -Y -p %u root@%s\\n" \
$HOSTFWDP $HOSTIP
printf "\\n"
} >&2
exec nice -- $QPATH/bin/qemu-system-x86_64 \
-no-user-config \
-nodefaults \
-nodefconfig \
\
-enable-kvm \
-S \
\
-m 2G \
-smp 2 \
\
-bios $HOME/OVMF.fd \
-global PIIX4_PM.disable_s3=0 \
-global PIIX4_PM.disable_s4=0 \
\
-global isa-debugcon.iobase=0x402 \
-debugcon file:$HOME/$GUEST.debug \
\
-chardev stdio,id=stdio \
-mon chardev=stdio,mode=readline,default \
-msg timestamp=on \
\
-chardev socket,id=unix0,server,nowait,path=$SOCK \
-device isa-serial,chardev=unix0 \
\
-usbdevice tablet \
\
-display vnc=$HOSTIP:0,tls,share=allow-exclusive \
-vga cirrus \
\
-drive id=drive-hd,file=$HOME/$GUEST.img,if=none,cache=writeback,format=qcow2
\
-device virtio-blk-pci,drive=drive-hd,bootindex=$BI_HD \
\
-drive
id=drive-app,file=$HOME/Edk2-AppPkg.img,if=none,cache=writeback,format=qcow2 \
-device virtio-blk-pci,drive=drive-app \
\
-drive
id=drive-sbk,file=$HOME/sb-keys.img,if=none,cache=writeback,format=qcow2 \
-device virtio-blk-pci,drive=drive-sbk \
\
-drive
id=drive-cd,file=$CD,if=none,cache=writeback,format=raw,media=cdrom,readonly \
-device ide-cd,drive=drive-cd,bootindex=$BI_CD \
\
-netdev
user,id=netdev0,hostname=$GUEST,tftp=$HOME/tftp.d,bootfile=ovmf.pxe.Shell.efi,hostfwd=tcp:$HOSTIP:$HOSTFWDP-:22
\
-device
virtio-net-pci,romfile=$QPATH/share/qemu/pxe-virtio.rom,netdev=netdev0,bootindex=$BI_NET
\
\
"$@"
------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13.
http://pubads.g.doubleclick.net/gampad/clk?id=64545871&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel