Just one example
------------
ASSERT(FullCommandLine == NULL);
//
// Now we need to include a NULL terminator in the size.
//
Size = LoadedImage->LoadOptionsSize + sizeof(FullCommandLine[0]);
------------
It means NULL POINTER DEREFERENCING
On 29.09.2013, at 16:58, Sergey Isakov <isakov...@bk.ru> wrote:
> Dear ShellPkg maintainers,
> How long I will wait for Shell that will not ASSERT on bad user input?
> I type "space" and "enter" and got ASSERT with CPU hang. Why? It must said
> that the command is wrong!
> Now I got a message that ASSERT… = Invalid parameter referring to
> MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c(815).
> I may propose that the Library is good but the Shell tends to call it wrong
> way, but there is no info about caller.
>
> ShellPkg$ cat */*/*.c | grep ASSERT | wc -l
> 903
>
> I claim again that such ASSERT using means bad programming style.
>
> Sergey.
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
