OK, I'm really stopping for today. Corrections: On 10/29/13 17:28, Laszlo Ersek wrote:
> This comment is stale -- see near the implementation of the > VirtioAppendDesc() function. Clearly the function in question is VirtioFlush(). > (3) The error handling is wrong, you need to assign EFI_UNSUPPORTED to > Status, and goto CloseVirtIo. > > (Actually I wonder if this check is necessary here at all. The system > should never invoke the BindingStart() function when the > BindingSupported() function returns EFI_SUCCESS. ... returns *something else than* EFI_SUCCESS. > > And, if VirtioBlkDriverBindingSupported() returns EFI_SUCCESS, then this > check will always evaluate to TRUE, so the goto will be dead code.) ... evaluate to FALSE ... Sigh. Laszlo ------------------------------------------------------------------------------ Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
