On Wed, Nov 20, 2013 at 09:29:22AM +0000, Zeng, Star wrote: > Hi Gary, > > Thank you for catching the missing. > > How about to remove the EFIAPI of PeiGetPcdInfo () in Service.h to align with > DxeGetPcdInfo (). > I am fine with it since it's a internal function.
Gary Lin > Star > -----Original Message----- > From: Gary Ching-Pang Lin [mailto:g...@suse.com] > Sent: Wednesday, November 20, 2013 5:06 PM > To: edk2-devel@lists.sourceforge.net > Subject: [edk2] [PATCH] MdeModulePkg Pcd: Add the missing attribute > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gary Ching-Pang Lin <g...@suse.com> > --- > MdeModulePkg/Universal/PCD/Pei/Service.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MdeModulePkg/Universal/PCD/Pei/Service.c > b/MdeModulePkg/Universal/PCD/Pei/Service.c > index e42d045..6ae190c 100644 > --- a/MdeModulePkg/Universal/PCD/Pei/Service.c > +++ b/MdeModulePkg/Universal/PCD/Pei/Service.c > @@ -236,6 +236,7 @@ ExGetPcdInfo ( > @retval EFI_NOT_FOUND The PCD service could not find the requested > token number. > **/ > EFI_STATUS > +EFIAPI > PeiGetPcdInfo ( > IN CONST EFI_GUID *Guid, > IN UINTN TokenNumber, > -- > 1.8.1.4 > > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech innovation. > Intel(R) Software Adrenaline delivers strategic insight and game-changing > conversations that shape the rapidly evolving mobile landscape. Sign up now. > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech innovation. > Intel(R) Software Adrenaline delivers strategic insight and game-changing > conversations that shape the rapidly evolving mobile landscape. Sign up now. > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
