Jordan, Got you! Thanks!
Jeff -----Original Message----- From: Justen, Jordan L Sent: Tuesday, November 26, 2013 5:33 PM To: Fan, Jeff; Ni, Ruiyu Cc: edk2-devel@lists.sourceforge.net; Laszlo Ersek Subject: OvmfPkg contributions - Re: [edk2] SVN r14885 breaks OVMF On Tue, 2013-11-26 at 06:21 +0100, Laszlo Ersek wrote: > as soon as Timer.efi is installed and the first timer interrupt is > delivered, OVMF hangs with the VCPU spinning at 100%. > > I can see that SVN r14887 is the commit that directly switches the > libraries that OvmfPkg uses. > > However, at that point "MdeModulePkg/Library/CpuExceptionHandlerLibNull" > (or other OvmfPkg dependencies) are already broken. Because if I > revert just r14887, then the busy loop related to the timer interrupt > is replaced by a reboot, at the same spot -- after Timer.efi is loaded > and the first interrupt is delivered. Different symptom (infinite > reboot loop), unusable just the same. > > I have to revert r14885 too, to get it working again. > > I guess at least Jordan could be invited to participate in Intel-only > patch reviews, if the patches change OvmfPkg. No, that process (Intel-only patch reviews) will not work for OvmfPkg. All OvmfPkg changes should be code reviewed on edk2-devel before being committed. I also think that EDK II's change process strongly encourages that the package owner (in the case, me) give some kind of Review or Ack (acknowledgement) of the patch. Jeff, Ray, I greatly appreciate any/all OvmfPkg contributions, but please follow this process in the future. (Also, please consider following this process for contributions to other packages as well. It will be better for EDK II.) -Jordan ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
