Martin:
The patch is good.
Reviewed-by: Liming Gao liming....@intel.com<mailto:liming....@intel.com>
Thanks
Liming
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Friday, November 29, 2013 6:00 AM
To: edk2-devel@lists.sourceforge.net; linaro-uefi-internal
Cc: edk2-buildtools-de...@lists.sourceforge.net
Subject: [edk2-buildtools] [PATCH] Enabling DRAM above the 32bit address space
on AArch64
Here is the patch to enable DRAM region located above the 32-bit address space
in UEFI.
This patch works fine on AArch64. It needs to be applied on SVN rev 14915
(2013-11-28 21:40:48).
This change has been validated on the FVP AArch64 model using 4GB
of DRAM at 0x8_0000_0000:
- # System Memory (2GB)
- gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
- gArmTokenSpaceGuid.PcdSystemMemorySize|0x80000000
+ # System Memory (4GB)
+ gArmTokenSpaceGuid.PcdSystemMemoryBase|0x800000000
+ gArmTokenSpaceGuid.PcdSystemMemorySize|0x100000000
EFI Shell and Linux kernel boot successfully on this use case.
This patch breaks the AArch32 builds. The compilers do not recognize the format
0x800000000ULL (ie: the 'ULL').
To fix the AArch32 build you need to change BaseTools/Conf/build_rule.template
such as:
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -166,7 +166,7 @@
<Command.GCC, Command.RVCT>
"$(PP)" $(PP_FLAGS) $(INC) ${src} > ${d_path}(+)${s_base}.i
- Trim --source-code -o ${d_path}(+)${s_base}.iii ${d_path}(+)${s_base}.i
+ Trim --trim-long --source-code -o ${d_path}(+)${s_base}.iii
${d_path}(+)${s_base}.i
# For RVCTCYGWIN ASM_FLAGS must be first to work around pathing issues
"$(ASM)" $(ASM_FLAGS) -o ${dst} $(INC) ${d_path}(+)${s_base}.iii
I will push this change in SVN repository when this change will be accepted by
the BaseTools team and rollback into the SVN EDK2.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin
olivier.mar...@arm.com<mailto:olivier.mar...@arm.com>
Thanks,
Olivier
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
