Jordan/Wei, Does Xen care about the PCI option rom? Because I just found the PciBusNoEnumerationDxe driver support dispatching the UEFI option rom loaded by the PciRootBridgeNoEnumerationDxe driver. PciRootBridgeNoEnumerationDxe installs an option ROM buffer table to configuration table to be retrieved by PciBusNoEnumerationDxe.
One possible way to resolve this and safely retire PciBusNoEnumerationDxe is to change PciBus driver full enumeration logic to also install the option rom buffer table to configuration table, instead of to save it in a global variable. Thanks, Ray -----Original Message----- From: Jordan Justen [mailto:jljus...@gmail.com] Sent: Wednesday, December 04, 2013 3:44 AM To: Ni, Ruiyu Cc: edk2-devel@lists.sourceforge.net; Wei Liu Subject: Re: [edk2] [PATCH v4 1/7] MdeModulePkg: introduce PcdPciDisableBusEnumeration On Tue, Dec 3, 2013 at 1:30 AM, Ni, Ruiyu <ruiyu...@intel.com> wrote: > For your information, I tried to replace the DUET PciBus driver using > MdeModulePkg one. > It works well after a small fix to the DUET PciRootBridgeNoEnumerationDxe > driver. Nice. :) I wonder if there is a chance of moving DUET to use PcAtChipsetPkg/PciHostBridgeDxe, since it appears to work for Xen with the no-enumeration PCD. -Jordan > -----Original Message----- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Tuesday, December 03, 2013 3:44 AM > To: Jordan Justen; Wei Liu > Cc: edk2-devel@lists.sourceforge.net; xen-devel > Subject: Re: [edk2] [PATCH v4 1/7] MdeModulePkg: introduce > PcdPciDisableBusEnumeration > > Jordan, > > Only rule is that TokenNumber must be unique within the TokenSpaceGuid. > > Reviewed-by: Michael Kinney <<michael.d.kin...@intel.com>> > > Mike > > -----Original Message----- > From: Jordan Justen [mailto:jljus...@gmail.com] > Sent: Saturday, November 30, 2013 3:56 PM > To: Kinney, Michael D; Wei Liu > Cc: xen-devel; edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] [PATCH v4 1/7] MdeModulePkg: introduce > PcdPciDisableBusEnumeration > > On Fri, Nov 29, 2013 at 6:13 AM, Wei Liu <wei.l...@citrix.com> wrote: >> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c >> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c >> index 5afbb82..cc6be8b 100644 >> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c >> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c >> @@ -284,7 +284,10 @@ PciBusDriverBindingStart ( >> ); >> } >> >> - gFullEnumeration = (BOOLEAN) ((SearchHostBridgeHandle (Controller) ? >> FALSE : TRUE)); >> + if (PcdGetBool (PcdPciDisableBusEnumeration)) >> + gFullEnumeration = FALSE; >> + else >> + gFullEnumeration = (BOOLEAN) ((SearchHostBridgeHandle (Controller) ? >> FALSE : TRUE)); > > Code style { } > > I think this could be fixed at commit time. > >> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec >> index b627eb1..5198451 100644 >> --- a/MdeModulePkg/MdeModulePkg.dec >> +++ b/MdeModulePkg/MdeModulePkg.dec >> @@ -878,6 +878,9 @@ >> ## This PCD specified whether the S.M.A.R.T feature of attached ATA hard >> disks are enabled. >> gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEnable|TRUE|BOOLEAN|0x00010065 >> >> + ## This PCD specifies whether full PCI enumeration is disabled. >> + >> gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|FALSE|BOOLEAN|0x10000048 > > Mike, > > Any preference on token number other than don't clash? > > Do you give your Reviewed-by for this patch? If so, I could take care > of committing it. > > -Jordan > > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
