On 10/31/13 01:35, Olivier Martin wrote: > Hi Fu, > > as you said according to the UEFI spec "all the fields in Snp.Mode > structure must be discovered during driver initialization". > > I sent an email to USWG and the Network subteam to ask for > clarification about this statement a few months ago. And no one has > replied so far. So my guess is everyone is confused by the statement > of the UEFI spec! > My next step is to send an ECR to clarify the statement in the UEFI > spec and make 'Snp->Initialize()' responsability to initialize the > structure... > If USWG prefer the driver binding start function be responsible for > the initialization then I would like to see this clarification in the > UEFI spec.
This is a good question. OvmfPkg/VirtioNetDxe does populate Snp.Mode in the driver binding start function. But in order to do so, as it must publish the MAC address and the media present status, it needs to bring up the card temporarily (and then shut it down). VirtioNetDriverBindingStart() [OvmfPkg/VirtioNetDxe/DriverBinding.c] VirtioNetSnpPopulate() VirtioNetGetFeatures() I assume this would be possible in the LAN9118 / LAN91x drivers too (although perhaps somewhat inconvenient). BTW is this the most recent version of the patchset? Thanks Laszlo ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel