I’m not a big fan of the bitfields, but given they are in the spec now I guess
they are OK.
The back story is we chose not to use bitfields in the Specs do to portability
issues, but we realized there was enough hardware centric code out in the world
that was using bitfields that to be safe we needed to add it to the ABI to be
safe, but we don’t intend to use bitfields in the spec.
Thanks,
Andrew Fish
On Dec 19, 2013, at 6:07 PM, Ni, Ruiyu <[email protected]> wrote:
> Jaben,
> It’s good to me.
>
> Thanks,
> Ray
>
> From: Carsey, Jaben
> Sent: Friday, December 20, 2013 6:59 AM
> To: Ni, Ruiyu
> Cc: 'Matthews, Robert ([email protected])';
> '[email protected]'; 'Phillips, Chris J (BCS CFE)
> ([email protected])'; Carsey, Jaben
> Subject: RE: MdePkg: Add PCI Express 2.1 and 3.0 structures
>
> Ray,
>
> I fixed each issue, can you please check this?
>
> Thanks!
> -Jaben
>
> MdePkg: Add PCI Express 2.1 and 3.0 structures
>
> This adds PCI Express extended capabilities structures. These structures are
> required for enhancements to the shell.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jaben Carsey <[email protected]>
>
>
> From: Ni, Ruiyu
> Sent: Thursday, December 12, 2013 9:29 PM
> To: Carsey, Jaben
> Cc: 'Matthews, Robert ([email protected])';
> '[email protected]'; 'Phillips, Chris J (BCS CFE)
> ([email protected])'
> Subject: RE: MdePkg: Add PCI Express 2.1 and 3.0 structures
> Importance: High
>
> Missed the UEFI spec statement.
> From: Ni, Ruiyu
> Sent: Friday, December 13, 2013 11:46 AM
> To: Carsey, Jaben
> Cc: 'Matthews, Robert ([email protected])';
> '[email protected]'; 'Phillips, Chris J (BCS CFE)
> ([email protected])'
> Subject: RE: MdePkg: Add PCI Express 2.1 and 3.0 structures
>
> Jaben,
> I withdraw my words about the forbidden of bitfield usage. Since UEFI spec
> already added the below statement, I think using bitfield is ok.
> Bitfields are ordered such that bit 0 is the least significant bit
>
> Below is my comments to the header file definition:
>
> 1. UncorrectableStatus -> UncorrectableErrorStatus
> 2. ErrorSourceIdentification -> ErrorSourceIdentification and
> CorrectableErrorSourceIdentification
> 3. ExtendedVcCount2->VcArbTableOffset
> 4.
> PCI_EXPRESS_EXTENDED_CAPABILITIES_LINK_CONTROL->PCI_EXPRESS_EXTENDED_CAPABILITIES_INTERNAL_LINK_CONTROL
> 5. #define
> PCI_EXPRESS_EXTENDED_CAPABILITIES_MULTI_FUNCTION_VIRTUAL_CHANNEL_CAPABILITY
> PCI_EXPRESS_EXTENDED_CAPABILITIES_VIRTUAL_CHANNEL_CAPABILITY -> use typedef
> is better?
> 6. ResizableBarControlRegister->ResizableBarControl
> 7. TphRequestorCapability/TphRequestorControl ->
> TphRequesterCapability/TphRequesterControl? ( “or” is your intention?)
>
> Thanks,
> Ray
>
> From: Ni, Ruiyu
> Sent: Friday, December 13, 2013 10:16 AM
> To: Carsey, Jaben
> Cc: Matthews, Robert ([email protected]);
> [email protected]; Phillips, Chris J (BCS CFE) ([email protected])
> Subject: RE: MdePkg: Add PCI Express 2.1 and 3.0 structures
>
> Jaben,
> Please do not use bit field syntax (e.g.: UINT32 DataSelect:8) in the PCIE
> header files. Because the bits order may be different across compilers.
>
> Thanks,
> Ray
>
> From: Carsey, Jaben
> Sent: Friday, December 13, 2013 1:12 AM
> To: Ni, Ruiyu
> Cc: Matthews, Robert ([email protected]);
> [email protected]; Phillips, Chris J (BCS CFE)
> ([email protected]); Carsey, Jaben
> Subject: MdePkg: Add PCI Express 2.1 and 3.0 structures
>
> Ni Ruiyu,
>
> Can you review this?
>
> MdePkg: Add PCI Express 2.1 and 3.0 structures
>
> This adds PCI Express extended capabilities structures. These structures are
> required for enhancements to the shell.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jaben Carsey <[email protected]>
>
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT
> organizations don't have a clear picture of how application performance
> affects their revenue. With AppDynamics, you get 100% visibility into your
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk_______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
