On Fri, Dec 27, 2013 at 12:03 PM, Laszlo Ersek <[email protected]> wrote: > On 12/26/13 22:08, Jordan Justen wrote: >> Reviewed-by: Jordan Justen <[email protected]> >> >> I committed .inf portion of this. The .dsc parts are arguably a >> separate change anyhow. > > Strangely enough, they aren't :) If you change the INF only, dropping > the dependency, then the build breaks unless you also resolve the > MemoryAllocationLib library class for DXE_SMM_DRIVER. That's why I said > "This in turn requires resolving MemoryAllocationLib for > DXE_SMM_DRIVERs." in the commit message. > > Honestly I had no clue why this happened but decided against tracking > down even this one. > > Doesn't the build break for you with only the INF portion committed?
I don't have any SMM drivers or SMM library sections in my build. :) You'll want to add that when you add LibraryClasses.common.DXE_SMM_DRIVER to the .dsc. (Or, should I *if* rather than *when*? :) -Jordan ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
