Andrew: I attach my patch. Please help review. Thanks Liming From: Andrew Fish [mailto:[email protected]] Sent: Saturday, January 04, 2014 5:44 AM To: [email protected] Subject: Re: [edk2] MdePkg bug in S3BootScriptLib.h
Liming,
Sorry I just noticed another typo: tble, should be table.
/**
This is an function to close the S3 boot script table. The function could only
be called in BOOT time phase. To comply with the Framework spec definition on
EFI_BOOT_SCRIPT_SAVE_PROTOCOL.CloseTable(), this function will fulfill
following things:
1. Closes the specified boot script table
2. It allocates a new memory pool to duplicate all the boot scripts in the
specified table.
Once this function is called, the table maintained by the library will be
destroyed
after it is copied into the allocated pool.
3. Any attempts to add a script record after calling this function will cause
a
new table to be created by the library.
4. The base address of the allocated pool will be returned in Address. Note
that
after using the boot script table, the CALLER is responsible for freeing
the
pool that is allocated by this function.
In Spec PI1.1, this EFI_BOOT_SCRIPT_SAVE_PROTOCOL.CloseTable() is retired.
This
API is supplied here to meet the requirements of the Framework Spec.
If anyone does call CloseTable() on a real platform, then the caller is
responsible
for figuring out how to get the script to run on an S3 resume because the
boot script
maintained by the lib will be destroyed.
@return the base address of the new copy of the boot script tble.
**/
UINT8*
EFIAPI
S3BootScriptCloseTable (
VOID
);
Thanks,
Andrew Fish
On Jan 2, 2014, at 5:30 PM, Gao, Liming
<[email protected]<mailto:[email protected]>> wrote:
Andrew:
Thanks for your catch. I attach my patch to correct it.
Thanks
Liming
From: Andrew Fish [mailto:[email protected]]
Sent: Friday, January 03, 2014 5:15 AM
To: [email protected]<mailto:[email protected]>
Subject: [edk2] MdePkg bug in S3BootScriptLib.h
MdePkg Maintainer,
There is a yank put bug in the comment for S3BootScriptSaveDispatch2() in the
S3BootScriptLib.
Thanks,
Andrew Fish
https://svn.code.sf.net/p/edk2/code/trunk/edk2/MdePkg/Include/Library/S3BootScriptLib.h
/**
Adds a record for an execution stall on the processor into a specified boot
script table.
@param[in] EntryPoint The entry point of the code to be dispatched.
@param[in] Context The argument to be passed into the EntryPoint of the
code
to be dispatched.
@retval RETURN_OUT_OF_RESOURCES Not enough memory for the table to perform
the operation.
@retval RETURN_SUCCESS The opcode was added.
**/
RETURN_STATUS
EFIAPI
S3BootScriptSaveDispatch2 (
IN VOID *EntryPoint,
IN VOID *Context
);
<S3BootScript.patch>------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk_______________________________________________
edk2-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/edk2-devel
BootScript.patch
Description: BootScript.patch
------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
