On Thu, Jan 9, 2014 at 2:00 PM, Laszlo Ersek <[email protected]> wrote: > On 01/09/14 22:47, Jordan Justen wrote: >> On Thu, Jan 9, 2014 at 12:41 PM, Laszlo Ersek <[email protected]> wrote: >>> On 01/09/14 01:45, Jordan Justen wrote: >>>> From: Laszlo Ersek <[email protected]> >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Laszlo Ersek <[email protected]> >>>> [[email protected]: move to MemDetect.c; use PCDs] >>> >>> PCDs are fine of course, but MemDetect() is not called on Xen >>> (unless that's the intent, but please explain then). >> >> I don't think this series claims to enable S3 for Xen, right? >> >> When someone looks at S3 for Xen, I might try to steer them towards >> having Xen call MemDetect again, and branch of for Xen specific things >> within MemDetect. I was not too excited about that aspect of r14946. > > No, the series doesn't *claim* to do that :), and I didn't test it, but > since I could not see any immediate blocker when running on Xen, I > figured we should add the feature generally, and then Xen users could > happily hunt bugs in the common code. By adding code that doesn't run > specifically on Xen we're making that harder.
I'll try to update this to make a best effort of having S3 potentially work for Xen. We should probably see if someone from xen-devel can verify that we haven't managed to break normal OVMF boots on Xen (aside from the S3 issue). -Jordan > ... I guess at least! :) I don't have proof either way. > > Also (but I didn't investigate this in particular) it's not that all > S3-related stuff were non-Xen only. Some of it seems to be Xen and KVM, > and some non-Xen only. But again I could be wrong. > > Anyway if we declare this, then I'll add my R-b to the patches where Xen > was my only question. > > Thanks! > Laszlo > ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
