The patch I sent out already removes this... just awaiting code review.
-----Original Message----- From: Jordan Justen [mailto:[email protected]] Sent: Friday, January 10, 2014 2:22 PM To: Carsey, Jaben Cc: [email protected] Subject: GCC build error - Re: SF.net SVN: edk2:[15070] trunk/edk2/ShellPkg/Library/ UefiShellDebug1CommandsLib Importance: High On Thu, Jan 9, 2014 at 8:54 AM, <[email protected]> wrote: > Revision: 15070 > http://sourceforge.net/p/edk2/code/15070 > Author: jcarsey > Date: 2014-01-09 16:54:13 +0000 (Thu, 09 Jan 2014) > Log Message: > ----------- > ShellPkg: Add more output to PCI command for extended configuration. > > there is a new non-spec parameter "-_e" which allows additional information > output to be controlled. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jaben Carsey <[email protected]> > Reviewed-by: Ruiyu Ni <[email protected]> > > Modified Paths: > -------------- > trunk/edk2/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > > trunk/edk2/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni > > Modified: trunk/edk2/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > =================================================================== > --- trunk/edk2/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > 2014-01-09 08:47:03 UTC (rev 15069) > +++ trunk/edk2/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > 2014-01-09 16:54:13 UTC (rev 15070) > +/** > + Display Pcie extended capability details > + > + @param[in] HeadersBaseAddress The address of all the extended capability > headers. > + @param[in] HeaderAddress The address of this capability header. > + @param[in] PciExpressCapPtr The address of the PCIe capabilities > structure. > +**/ > +EFI_STATUS > +EFIAPI > +PrintPciExtendedCapabilityDetails( > + IN CONST PCI_EXP_EXT_HDR *HeadersBaseAddress, > + IN CONST PCI_EXP_EXT_HDR *HeaderAddress, > + IN CONST PCIE_CAP_STURCTURE *PciExpressCapPtr > + ) > +{ > + switch (HeaderAddress->CapabilityId){ > + case PCI_EXPRESS_EXTENDED_CAPABILITY_ADVANCED_ERROR_REPORTING_ID: > + return PrintInterpretedExtendedCompatibilityAer(HeaderAddress, > HeadersBaseAddress); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_LINK_CONTROL_ID: > + return PrintInterpretedExtendedCompatibilityLinkControl(HeaderAddress, > HeadersBaseAddress); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_LINK_DECLARATION_ID: > + return > PrintInterpretedExtendedCompatibilityLinkDeclaration(HeaderAddress, > HeadersBaseAddress); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_SERIAL_NUMBER_ID: > + return > PrintInterpretedExtendedCompatibilitySerialNumber(HeaderAddress, > HeadersBaseAddress); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_POWER_BUDGETING_ID: > + return > PrintInterpretedExtendedCompatibilityPowerBudgeting(HeaderAddress, > HeadersBaseAddress); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_ACS_EXTENDED_ID: > + return PrintInterpretedExtendedCompatibilityAcs(HeaderAddress, > HeadersBaseAddress); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_LATENCE_TOLERANCE_REPORTING_ID: > + return > PrintInterpretedExtendedCompatibilityLatencyToleranceReporting(HeaderAddress, > HeadersBaseAddress); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_ARI_CAPABILITY_ID: > + return PrintInterpretedExtendedCompatibilityAri(HeaderAddress, > HeadersBaseAddress); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_RCRB_HEADER_ID: > + return PrintInterpretedExtendedCompatibilityRcrb(HeaderAddress, > HeadersBaseAddress); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_VENDOR_SPECIFIC_ID: > + return > PrintInterpretedExtendedCompatibilityVendorSpecific(HeaderAddress, > HeadersBaseAddress); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_DYNAMIC_POWER_ALLOCATION_ID: > + return > PrintInterpretedExtendedCompatibilityDynamicPowerAllocation(HeaderAddress, > HeadersBaseAddress); > + break; > + case > PCI_EXPRESS_EXTENDED_CAPABILITY_EVENT_COLLECTOR_ENDPOINT_ASSOCIATION_ID: > + return PrintInterpretedExtendedCompatibilityECEA(HeaderAddress, > HeadersBaseAddress); > + break; > +/** > + case PCI_EXPRESS_EXTENDED_CAPABILITY_VIRTUAL_CHANNEL_ID: > + case PCI_EXPRESS_EXTENDED_CAPABILITY_MULTI_FUNCTION_VIRTUAL_CHANNEL_ID: > + ASSERT(FALSE); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_MULTICAST_ID: > +// use PCIE_CAP_DEVICEPORT_TYPE(PciExpressCapPtr->PcieCapReg) == 0100b, > 0101b, or 0110b > + ASSERT(FALSE); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_RESIZABLE_BAR_ID: > + ASSERT(FALSE); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_TPH_ID: > + ASSERT(FALSE); > + break; > + case PCI_EXPRESS_EXTENDED_CAPABILITY_SECONDARY_PCIE_ID: > + // use PciExpressCapPtr link capabilities register > + ASSERT(FALSE); > + break; > +//**/ This causes a GCC warning (and thus error): ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c: In function 'PrintPciExtendedCapabilityDetails': ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c:5116:2: error: "/*" within comment [-Werror=comment] //**/ ^ Did we want this commented block? -Jordan > + default: > + ShellPrintEx (-1, -1, > + L"Unknown PCIe extended capability ID (%04xh). No interpretation > available.\r\n", > + HeaderAddress->CapabilityId > + ); > + return EFI_SUCCESS; > + break; > + }; > + > +} > + > +/** ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
